Closed Bug 626142 Opened 12 years ago Closed 12 years ago

Fix plug-in dtd

Categories

(Camino Graveyard :: Plug-ins, defect)

All
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Camino2.1

People

(Reporter: alqahira, Assigned: alqahira)

Details

Attachments

(1 file)

The plug-in blocklisting and disabling uses http://mxr.mozilla.org/mozilla1.9.2/source/toolkit/locales/en-US/chrome/mozapps/plugins/plugins.dtd which is full of incorrect and Firefox-specific strings.  (Even worse, they're not localizable :( ).

We'll have to fork the file and fix the strings.
This is at least *a* fix; it fixes the three strings we care about by forking both the DTD and the XBL, splitting the strings, and inserting the links.

It requires a new section on cbo's Setup page at http://caminobrowser.org/documentation/setup/#disable_plugin to explain disabled plug-ins.  (We may want to add a similar link to the blocked plug-ins message.)  We might also want to just change the link to "More info." or something, because space is often at a premium (see the first Java instance on http://browserspy.dk/java.php).

I'm still hopeful I might be able to figure out stringbundle-in-XBL to make this localizable, but this at least makes it useable.
(In reply to comment #1)
> I'm still hopeful I might be able to figure out stringbundle-in-XBL to make
> this localizable, but this at least makes it useable.

I'm significantly less hopeful now.
Flags: camino2.1b1+
Comment on attachment 504194 [details] [diff] [review]
non-localizable fix

We may still want to change the URL for disabled (to go to hidden prefs, since other than Java, disabling is all backed by hidden prefs), but for now this at least gets an improved version of this UI ready to land with bug 558432 and friends.
Attachment #504194 - Flags: superreview?(stuart.morgan+bugzilla)
Comment on attachment 504194 [details] [diff] [review]
non-localizable fix

sr=smorgan
Attachment #504194 - Flags: superreview?(stuart.morgan+bugzilla) → superreview+
http://hg.mozilla.org/camino/rev/b4d8934369ae with 'target="_blank"' added to the two links.

We'll track any other changes to this mess in new bugs.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.