Closed Bug 626148 Opened 14 years ago Closed 14 years ago

Opening link in new tab from background window opens tab in foreground window

Categories

(Firefox :: General, defect)

Product:
Firefox
Component:
General
Platform:
x86_64
macOS
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 4.0b11

People

(Reporter: gomozilla, Assigned: dao)

References

Details

(Keywords: regression)

Attachments

(1 file, 1 obsolete file)

patch v2
1.03 KB, patch
Dolske
: review+
Dolske
: approval2.0+
Details | Diff | Splinter Review
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b9) Gecko/20100101 Firefox/4.0b9 Build Identifier: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b9) Gecko/20100101 Firefox/4.0b9 When opening a new tab from a link in an existing tab, the new tab opens in the currently-focused window, not the parent window of the existing tab. Reproducible: Always Steps to Reproduce: 1. Open a page in one window 2. Open a new window with another page, positioning it so both windows are visible 3. Right-click a link on the non-focused window and choose to open it in a new tab Actual Results: The tab opens in the focused window Expected Results: The new tab should open next to the tab containing the link
Version: unspecified → Trunk
That's a regression in Firefox 4.0. It works fine with Firefox 3.6.13. We should check for a regression range.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: regression, regressionwindow-wanted
Regressed between Beta 8 and Beta 9. Digging more into...
Regressed between 10122503 and 10122603: PASS: http://hg.mozilla.org/mozilla-central/rev/0ab0603bea99 FAIL: http://hg.mozilla.org/mozilla-central/rev/f5eb60e1bc6e Checkins: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=0ab0603bea99&tochange=f5eb60e1bc6e Regressed by: Bug 606678 - use openLinkIn in nsContextMenu ("Open Link in New Tab" shouldn't add tabs to popups). r=gavin a=b author Dão Gottwald <dao@mozilla.com> Sat Dec 25 00:11:45 2010 +0100 (at Sat Dec 25 00:11:45 2010 +0100)
Blocks: 606678
Keywords: regressionwindow-wanted
Assignee: nobody → dao
Component: Tabbed Browser → General
QA Contact: tabbed.browser → general
Summary: Opening Link in New Tab from Background Window Opens Tab in Wrong Window → Opening link in new tab from background window opens tab in foreground window
Attached patch patch (obsolete) — — Splinter Review
Attachment #505385 - Flags: review?(dolske)
Attachment #505385 - Flags: review?(gavin.sharp)
Comment on attachment 505385 [details] [diff] [review] patch You have |if (a && b || c)|, but I think you mean |if (a && (b || c))|.
Attachment #505385 - Flags: review?(dolske) → review-
Attached patch patch v2 — — Splinter Review
Attachment #505385 - Attachment is obsolete: true
Attachment #507387 - Flags: review?(gavin.sharp)
Attachment #507387 - Flags: review?(dolske)
Attachment #505385 - Flags: review?(gavin.sharp)
Attachment #507387 - Flags: review?(gavin.sharp)
Attachment #507387 - Flags: review?(dolske)
Attachment #507387 - Flags: review+
Attachment #507387 - Flags: approval2.0+
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/a63f1b9d9878
Status: NEW → RESOLVED
Closed: 14 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b11
No longer blocks: FF2SM
Verified fixed with Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b11pre) Gecko/20110202 Firefox/4.0b11pre ID:20110202030356 Would be great to have an automated test here.
Status: RESOLVED → VERIFIED
Flags: in-testsuite?
Blocks: 429166
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: