Closed
Bug 626148
Opened 13 years ago
Closed 13 years ago
Opening link in new tab from background window opens tab in foreground window
Categories
(Firefox :: General, defect)
Tracking
()
VERIFIED
FIXED
Firefox 4.0b11
People
(Reporter: gomozilla, Assigned: dao)
References
Details
(Keywords: regression)
Attachments
(1 file, 1 obsolete file)
|
1.03 KB,
patch
|
Dolske
:
review+
Dolske
:
approval2.0+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b9) Gecko/20100101 Firefox/4.0b9 Build Identifier: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b9) Gecko/20100101 Firefox/4.0b9 When opening a new tab from a link in an existing tab, the new tab opens in the currently-focused window, not the parent window of the existing tab. Reproducible: Always Steps to Reproduce: 1. Open a page in one window 2. Open a new window with another page, positioning it so both windows are visible 3. Right-click a link on the non-focused window and choose to open it in a new tab Actual Results: The tab opens in the focused window Expected Results: The new tab should open next to the tab containing the link
|
Reporter | |
Updated•13 years ago
|
Version: unspecified → Trunk
|
||
Comment 1•13 years ago
|
||
That's a regression in Firefox 4.0. It works fine with Firefox 3.6.13. We should check for a regression range.
|
|
||
Comment 2•13 years ago
|
||
Regressed between Beta 8 and Beta 9. Digging more into...
|
|
||
Comment 3•13 years ago
|
||
Regressed between 10122503 and 10122603: PASS: http://hg.mozilla.org/mozilla-central/rev/0ab0603bea99 FAIL: http://hg.mozilla.org/mozilla-central/rev/f5eb60e1bc6e Checkins: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=0ab0603bea99&tochange=f5eb60e1bc6e Regressed by: Bug 606678 - use openLinkIn in nsContextMenu ("Open Link in New Tab" shouldn't add tabs to popups). r=gavin a=b author Dão Gottwald <dao@mozilla.com> Sat Dec 25 00:11:45 2010 +0100 (at Sat Dec 25 00:11:45 2010 +0100)
Blocks: 606678
Keywords: regressionwindow-wanted
|
Assignee | |
Updated•13 years ago
|
Assignee: nobody → dao
Component: Tabbed Browser → General
QA Contact: tabbed.browser → general
|
|
Assignee | |
Updated•13 years ago
|
Summary: Opening Link in New Tab from Background Window Opens Tab in Wrong Window → Opening link in new tab from background window opens tab in foreground window
|
|
Assignee | |
Comment 4•13 years ago
|
||
Attachment #505385 -
Flags: review?(dolske)
|
|
Assignee | |
Updated•13 years ago
|
Attachment #505385 -
Flags: review?(gavin.sharp)
|
||
Comment 5•13 years ago
|
||
Comment on attachment 505385 [details] [diff] [review] patch You have |if (a && b || c)|, but I think you mean |if (a && (b || c))|.
Attachment #505385 -
Flags: review?(dolske) → review-
|
|
Assignee | |
Comment 6•13 years ago
|
||
Attachment #505385 -
Attachment is obsolete: true
Attachment #507387 -
Flags: review?(gavin.sharp)
Attachment #507387 -
Flags: review?(dolske)
Attachment #505385 -
Flags: review?(gavin.sharp)
|
|
||
Updated•13 years ago
|
Attachment #507387 -
Flags: review?(gavin.sharp)
Attachment #507387 -
Flags: review?(dolske)
Attachment #507387 -
Flags: review+
Attachment #507387 -
Flags: approval2.0+
|
|
Assignee | |
Updated•13 years ago
|
Keywords: checkin-needed
|
||
Comment 7•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/a63f1b9d9878
Status: NEW → RESOLVED
Closed: 13 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b11
|
|
||
Comment 8•13 years ago
|
||
Verified fixed with Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b11pre) Gecko/20110202 Firefox/4.0b11pre ID:20110202030356 Would be great to have an automated test here.
Status: RESOLVED → VERIFIED
Flags: in-testsuite?
You need to log in
before you can comment on or make changes to this bug.
Description
•