626310 - Port |Bug 600435 - XULRunner universal for i386/x64_64 fails to unify nspr-config| to comm-central

Status: VERIFIED FIXED

(MailNews Core :: Build Config, defect)

Description

[Serge Gautherie (:sgautherie)]

After bug 600435 landing, SeaMonkey builds fail with:

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1295234000.1295234935.14052.gz
Linux comm-central-trunk build on 2011/01/16 19:13:20
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1295233998.1295234791.13661.gz
OS X 10.6 comm-central-trunk build on 2011/01/16 19:13:18
{
...
/builds/slave/comm-cen-trunk-lnx/build/mozilla/xpcom/glue/nsStringAPI.cpp:952: undefined reference to `PR_sscanf'
collect2: ld returned 1 exit status
make[5]: *** [libsuite.so] Error 1
}

I assume
http://hg.mozilla.org/mozilla-central/rev/9151e7c5577b
needs to be ported to comm-central.

NB: Fwiw, Thunderbird seems unaffected :-|

Comment 1

[Misak Khachatryan]

Attachment: straight copy/paste [Checked in: Comment 3]

I was able to build on Fedora 14 64 bit with this patch. Should work for all other platforms. Don't know right owner for review, it's late time for Callek, so KaiRO ;)

Comment 2

[Robert Kaiser]

Comment on attachment 504368 [details] [diff] [review]
straight copy/paste
[Checked in: Comment 3]

Haven't actually tested it, but looks good based on code inspection.

Comment 3

[Misak Khachatryan]

Pushed:
http://hg.mozilla.org/comm-central/rev/67dc0c9c045f

Comment 4

[Serge Gautherie (:sgautherie)]

Ftr, this bug affected Sunbird too:

http://tinderbox.mozilla.org/showlog.cgi?log=Sunbird/1295234117.1295234982.14155.gz
Linux comm-central lightning build on 2011/01/16 19:15:17
{
...
/builds/buildbot/comm-central-lightning-linux/build/mozilla/xpcom/glue/nsStringAPI.cpp:546: undefined reference to `PR_sscanf'
collect2: ld returned 1 exit status
make[7]: *** [libcalbasecomps.so] Error 1
}

*****

SB and SM builds are green again.

V.Fixed