626501 - [OS/2] build break in nsprpub/configure.in after checkin for bug618789

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Walter Meinl]

User-Agent:       Mozilla/5.0 (OS/2; Warp 4.5; rv:2.0b10pre) Gecko/20110113 Firefox/4.0b10pre
Build Identifier: 

E:/hg-src/hg/comm-central/mozilla/nsprpub/configure: 3307: Syntax error: word unexpected (expecting ")")
configure: error: E:/hg-src/hg/comm-central/mozilla/nsprpub/configure failed for nsprpub

This happened after checkin for bug618789
The OS/2 build breaks due usage of a macro not supported in nspr m4 files. The macro is not used for OS/2 however, it is inserted after checking for OS2_HIGH_MEM feature. Since the wording in the following macro appears to be faulty, the OS2 check isn't terminated properly.

see also https://bugzilla.mozilla.org/show_bug.cgi?id=618789#c13

I'm filing this bug against mozilla-central core build config because the changes to nsprpub/configure were done only in m-c and not (yet) in nspr CVS.

s/MOZ_ARG_WITH_STRING/AC_ARG_WITH unbreaks the OS/2 build

Reproducible: Always

Comment 1

[Walter Meinl]

Attachment: use the correct macro

romaxa, I don't have access to tryserver. Would it be possible for you to test whether this patch works for arm like it did in your original patch from bug618789?

Comment 2

[Mitchell Field [:Mitch]]

Comment on attachment 504557 [details] [diff] [review]
use the correct macro

Fine.

Comment 3

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 504557 [details] [diff] [review]
use the correct macro

The original change needs to be backed out, and that change and this need to be reviewed by the NSPR peers and be checked into CVS.

Comment 4

[Walter Meinl]

fixed by backout of the patch causing the problem
https://bugzilla.mozilla.org/show_bug.cgi?id=618789#c18
http://hg.mozilla.org/mozilla-central/rev/ac1ddab6de59