Closed Bug 626557 Opened 13 years ago Closed 13 years ago

previous tabs missing immediately after updating minefield, but appear on subsequent invocations

Categories

(Firefox :: Session Restore, defect)

Product:
Firefox
Component:
Session Restore
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
major

Tracking

()

Status:
VERIFIED WORKSFORME

People

(Reporter: GavinFlower, Unassigned)

Details

Attachments

(5 files)

bash script to download and install Minefield nightly
1.85 KB, text/plain
Details
preferences general for gavin
61.02 KB, image/png
Details
preferences general for gavinmf
62.61 KB, image/png
Details
preferences general for gavinxi
62.55 KB, image/png
Details
preferences general for gcf
62.47 KB, image/png
Details 
User-Agent:       Mozilla/5.0 (X11; Linux x86_64; rv:2.0b10pre) Gecko/20110117 Firefox/4.0b10pre
Build Identifier: Mozilla/5.0 (X11; Linux x86_64; rv:2.0b10pre) Gecko/20110117 Firefox/4.0b10pre

Since Firefox 4.0b10pre was released: each time I download a nightly:

(a) The first invocation of minefield shows up without any of the tabs that I had when I shut the previous invocation down.

(b) However, after shutting down this first invocation, the next invocation restores the tabs as they were prior to installing the latest minefield.

(c) Subsequent invocations, with the same version of Minefield,  correctly restore the tabs at the end of the previous invocation.

Reproducible: Always

Steps to Reproduce:
1. install latest nightly
2. invoke Minefield
3. ...
Actual Results:  
tabs missing 

Expected Results:  
tabs as they were when Minefield was last shutdown
Component: Tabbed Browser → Session Restore
QA Contact: tabbed.browser → session.restore
Version: unspecified → Trunk
Are you downloading the update from within Minefield and just pressing restart/apply or are you downloading a new copy, quitting, installing, and then starting again?
I am you downloading a new copy, killing via top, installing, and then
starting again.

I think today I killed the Minefield instances running, before I installed the new version.

I have 4 user ids (for different purposes, this is my main work machine as well as my hobby/personal machine!):

these 3 users are logged in for several days at a time
'gavin'   - Minefield is normally running the whole time I am logged in
'gavinmf' - Minefield is normally running the whole time I am logged in
'gavinxi' - Minefield is brought up from time to time, not normally running

this user is logged in for a few minutes every now and then
'gcf'     - Minefield is brought up from time to time, not normally running


From memory:
This morning I think 2 of them had the right behaviour, and 2 of them required invoking a second time.  Sorry this is vague, I will explicitly note what I do tomorrow!

I use the attached bash script to download and install a fresh copy of Minefield as 'root' each morning (NZDT New Zealand time zone).
When I checked for updates of plugins etc, there was a new version of shockwave flash.

I clicked the restart button, and it came back without the previous tabs.

I clicked on the kill icon in the top left of the Minefield window.  Then started a new instance from a menu open in GNOME.  This time the previous tabs re-appeared.
kill icon in the top __RIGHT__ of the Minefield window
Note I had just rebooted.

THen:
(1) I brought up Minefield for 'gavin' and 'gavinxi', then killed both via top.

(2) Updated to latest nightly using my bash script, build: 20110119030331

(3) Invoked Minefield for 'gavin' and 'gavinxi' (see Comment 2 above), in both cases they cam up with the option to restore.  I clicked restore and the previous tabs re-appeared.

(4) Invoked Minefield for 'gavinxi' and 'gcf', in both cases:
    (a) I got a dialogue to make Minfield the default, which I accepted.
    (b) The previous tabs were absent
    (c) I used the icon in the top right of the Minefield window
    (d) Invoked fresh instances
    (e) The previous tabs re-appeared.
Hmm...

I had been using Firefox 3.6.13 on another 64 bit computer running Fedora 14.  When I ran Minefield, it came up with a welcome page for Minefield, but no other tabs.  When I clicked on the window's kill icon and brought up another instance, the tabs that were there previously reappeared.
Build: 20110121030329

Same behaviour as in Comment 6 (except system had been up for more than a day).

This time: I noticed that for 'gavin' and 'gavinxi' that the help panel gave the latest build date - something I had not checked in comment 6.
(In reply to comment #2)
> Created attachment 504853 [details]
> bash script to download and install Minefield nightly

Based on this, it looks like you are paving over something which tells Minefield there is a previous session on startup.  After it has started, it finds what it needs to restore the session, so your next restart restores it.

Paul, what do you think?
Gavin, can you try simply updating via the Help>About dialog?  Do you lose your session through this path?
Interesting, I had to reboot and then immediately applied by script to download and install the latest Minefield nightly.

The first time I invoked an instance of Minefield as 'gavin' the tabs appeared, but not for user 'gcf'!!!

It will be a couple of days before I can follow the suggestion in Comment 10
When I clicked on the update via the Help>About dialog, it simply downloaded the latest Minefield file, which I would have to manually install.  This is the same file my script downloads - I checked by running my script, and it grabbed the copy from squid cache.

firefox-4.0b11pre.en-US.linux-x86_64
build:20110127030333

'gavin'
(nultiple Minefield windows in different virtual desktops)
kiiled instance via top

invoked new instance
came with old tabs
kiiled instance via top
invoked new instance
came with old tabs

'gavinmf'
(single Minefield window))
kiiled instance via top

invoked new instance
came with old tabs
killed instance via kill icon top right
invoked new instance
dialog came up to ask about making minefield the default
no old tabs
killed instance via kill icon top right
invoked new instance
came with old tabs

'gavinxi' & 'gcf'
(no existing instance of MInefield)
dialog came up to ask about making minefield the default
no old tabs
killed instance via kill icon top right
invoked new instance
came with old tabs
hmm...

I have not installed a new version of Minefield since the last comment, nor have I rebooted.

I just updated 'Tab Counter', and clicked on restart Firefox.  I came back sans tabs.  I killed it via the close icon, and invoked a new instance.  The original tabs came back.

Is there anyway I can provide more useful diagnostics?
So this only happens when Firefox want to restart itself, but never when you close/start Firefox on your own? What happens if you select "Help | Restart with Add-ons disabled"?
(In reply to comment #14)
> So this only happens when Firefox want to restart itself, but never when you
> close/start Firefox on your own? 

No.

It happens after I install a new version of Minefield
_AND_
when I restart after upgrading an add-on.

>                                  What happens if you select "Help | Restart
> with Add-ons disabled"?

I will try that next time I upgrade an add-on.
(In reply to comment #15)
> I will try that next time I upgrade an add-on.

Please try that right now independently from upgrading add-ons.
I disabled all add-ons, went into safe made, and restarted - all tabs re-appeared.

Then I re-enabled each add-on one by one, restarting each time.  In every case the original tabs re-appeared.
I used user 'gavin' - had 5 Minefield windows open, initially in different virtual desktops, but I did not reposition them after each restart.
hmm... weird

I just updated the same tab count add-on for user 'gavimf', and the original tabs re-appeared!
So please give upcoming updates an extra check. If you don't mind, create a backup of the profile before you update any of the add-ons. Then run the update twice. First with all your add-ons enabled, and second with all disabled.
I will take copies of the .mozilla directories and do stuff with all add-ons disabled later.  I got varieties of behaviours from my different userids!  I will include the list of add-ons for the various userids.
 
latest Minefield nightly 
	firefox-4.0b11pre.en-US.linux-x86_64.tar.bz2
	build: 20110129030338

'gavin'
had to separately kill npviewer
cp -R .mozilla .mozilla-20110130a
>>>>>>>> after installing latest Minefield nightly 
invoked an instance of Minefield
Minefield window came up with an option to restore 
all existing tabs appeared
the about dialog had the date 2011-01-29 (date of latest nightly)
killed instance
invoked new instance
exiting tabs appeared (no option to restore!)

'gavinmf'
cp -R .mozilla .mozilla-20110130a
>>>>>>>> after installing latest Minefield nightly 
Minefield window came up with an option to restore 
all existing tabs appeared
the about dialog had the date 2011-01-29 (date of latest nightly)
killed instance
invoked new instance
dialog to make Minefield the default appeared, I replied yes
existing tabs had gone
killed instance
invoked new instance
all existing tabs appeared


'gavinxi'
Minefield was not running, yet there was a run-mozilla.sh task, killed it
cp -R .mozilla .mozilla-20110130a
>>>>>>>> after installing latest Minefield nightly 
invoked new instance
dialog to make Minefield the default appeared, I replied yes
all existing tabs appeared
killed instance
invoked new instance
all existing tabs appeared


'gcf'
no logged in, but there were:
dbus-daemon and dbus-launch tasks running, ignored them
cp -R .mozilla .mozilla-20110130a
>>>>>>>> after installing latest Minefield nightly 
invoked new instance
dialog to make Minefield the default appeared, I replied yes
existing tabs had gone
killed instance
invoked new instance
all existing tabs appeared

//////////////////

Saturday 2011-01-29

'gavin'
Adblock Plus 1.3.3
British English Dictionary 1.19.1
Firebug 1.7X.0a9
Flashblock 1.5.14.2
HashColouredTabs+ 0.4.27
Inline Code Finder 0.95
NoScript 2.0.9.6
ShowIP 0.8.19
Status-4-Evar 2011.01.17.02
Tab Counter 1.8.8
Text Link 3.1.2009110201 (disabled)

Shockwave Flash 10.3.d162
Iced Tea NPR Web Browser Plugin (using Iced Tea 1.9.4... (disabled)
OpenOffice.org Plug-in (disabled)


'gavinmf'
Adblock Plus 1.3.3
British English Dictionary 1.19.1
Flashblock 1.5.14.2
HashColouredTabs+ 0.4.27
NoScript 2.0.9.6
Tab Counter 1.8.8
Firebug 1.5.4 (disabled)
Mozilla QA Companion 1.2.3 (disabled)
Text Link 3.1.2009110201 (disabled)
ShowIP 0.8.19 (disabled)

Iced Tea NPR Web Browser Plugin (using Iced Tea 1.9.4...
Shockwave Flash 10.3.d162

'gavinxi'
Adblock Plus 1.3.3
Firebug 1.7X.0a9
Flashblock 1.5.14.2
NoScript 2.0.9.6

Iced Tea NPR Web Browser Plugin (using Iced Tea 1.9.4...
Shockwave Flash 10.3.d162

'gcf'
Adblock Plus 1.3.3
British English Dictionary 1.19.1
Flashblock 1.5.14.2
HashColouredTabs+ 0.4.27
NoScript 2.0.9.6

Iced Tea NPR Web Browser Plugin (using Iced Tea 1.9.4...
Shockwave Flash 10.3.d162
(In reply to comment #20)
> So please give upcoming updates an extra check. If you don't mind, create a
> backup of the profile before you update any of the add-ons. Then run the update
> twice. First with all your add-ons enabled, and second with all disabled.

I thought I had understood your comment!

How can I update add-ons when all add-ons are disabled?
I have not done a detailed check, but it appears the same problems also apply to:

firefox-4.0b12pre.en-US.linux-x86_64
build: 20110202162900
What's the setting for "Preferences | General | When Minefield starts" for all those profiles?

    
    

    
  


  

    
    

    
  


  

    
    

    
  


  

    
    

    
  
Hmm...

The setting for "Preferences | General | When Minefield starts"for user 'gavin' was probably reset when I went into safe mode to diagnose another bug - I think it normally displays the previous tabs, i.e. the same as for the other userid's!

    
    

    
  
This problem seems to have been resolved.

I checked 
Mozilla/5.0 (X11; Linux x86_64; rv:2.0b12pre) Gecko/20110218 Firefox/4.0b12pre ID:20110218030352

Seems okay, and does not suffer from the problem in any of my 4 userid's.

Thanks.

Curious, was this a 'deliberate' fix, or did it result as a side effect of other changes?

    
    

    
  
There was no deliberate fix, so it was probably a side effect of something else (not sure what though).
Status: UNCONFIRMED → RESOLVED
Closed: 13 years ago
Resolution: --- → WORKSFORME

    
    

    
  
I'm unable to reproduce with Firefox 4.0b12pre 20110218 -- marking VERIFIED.
Status: RESOLVED → VERIFIED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: