Closed
Bug 626617
Opened 13 years ago
Closed 13 years ago
Remove Termiadur search plug-in on major update to 4.0
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: sethb, Unassigned)
References
Details
(Keywords: productization)
Attachments
(1 file)
758 bytes,
patch
|
nthomas
:
review+
johnath
:
approval2.0+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #538570 +++ Doing a major update from Welsh 3.6.x will not remove the searchplugins/termiadur.xml file. Attached is a patch to browser/installer/removed-files.in that should fix that (if I understand it correctly). Requesting review from nthomas. This should land on mozilla-1.9.2 and mozilla-central, I guess?
Attachment #504680 -
Flags: review?
Reporter | ||
Updated•13 years ago
|
Attachment #504680 -
Flags: review? → review?(nrthomas)
Comment 1•13 years ago
|
||
(In reply to comment #0) > This should land on mozilla-1.9.2 and mozilla-central, I guess? Only mozilla-central. The change in bug 601913 only landed on l10n-central.
Comment 2•13 years ago
|
||
(In reply to comment #1) > (In reply to comment #0) > > This should land on mozilla-1.9.2 and mozilla-central, I guess? > Only mozilla-central. The change in bug 601913 only landed on l10n-central. Agreed, we'd remove termiadur for 3.6.x -> 3.6.x+1 updates if it lands on 1.9.2.
Blocks: 601913
Comment 3•13 years ago
|
||
Comment on attachment 504680 [details] [diff] [review] [checked in] Adding termiadu.xml to removed-files.in Looks fine to me, and seems unlikely that any other locale is using a welsh-english translation.
Attachment #504680 -
Flags: review?(nrthomas) → review+
Comment 4•13 years ago
|
||
Hi, it should be "termiadur.xml" (with an "r" before the dot). The text in the attachment looks correct to me so I presume that's all that matters, but I just wanted to check. Thanks!
Reporter | ||
Comment 5•13 years ago
|
||
(In reply to comment #4) > Hi, it should be "termiadur.xml" (with an "r" before the dot). The text in the > attachment looks correct to me so I presume that's all that matters, but I just > wanted to check. Thanks! Got it...small typo in the patch description, but you are right, it's correctly spelled in the remove-files.in patch.
Reporter | ||
Comment 6•13 years ago
|
||
I don't think I have hg access to mozilla-central. Can Pike or nrthomas check in this patch? Thanks!
Comment 7•13 years ago
|
||
You'll need to hunt for blocking status for the bug or approval for the patch before landing.
Comment 8•13 years ago
|
||
Comment on attachment 504680 [details] [diff] [review] [checked in] Adding termiadu.xml to removed-files.in Approved for 2.0 landing.
Attachment #504680 -
Flags: approval2.0+
Comment 9•13 years ago
|
||
Fixing up summary to match the effect the patch will have.
Summary: Remove Termiadur search plug-in on major update from 3.6.x → Remove Termiadur search plug-in on major update to 4.0
Comment 10•13 years ago
|
||
Comment on attachment 504680 [details] [diff] [review] [checked in] Adding termiadu.xml to removed-files.in http://hg.mozilla.org/mozilla-central/rev/6b5a47683b88
Attachment #504680 -
Attachment description: Adding termiadu.xml to removed-files.in → [checked in] Adding termiadu.xml to removed-files.in
Updated•13 years ago
|
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•5 years ago
|
Component: Build Config → General
Product: Firefox → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•