626617 - Remove Termiadur search plug-in on major update to 4.0

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Seth Bindernagel]

Attachment: [checked in] Adding termiadu.xml to removed-files.in

+++ This bug was initially created as a clone of Bug #538570 +++

Doing a major update from Welsh 3.6.x will not remove the searchplugins/termiadur.xml file. Attached is a patch to browser/installer/removed-files.in that should fix that (if I understand it correctly). Requesting review from nthomas.

This should land on mozilla-1.9.2 and mozilla-central, I guess?

Comment 1

[Staś Małolepszy :stas]

(In reply to comment #0)
 
> This should land on mozilla-1.9.2 and mozilla-central, I guess?

Only mozilla-central. The change in bug 601913 only landed on l10n-central.

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

(In reply to comment #1)
> (In reply to comment #0)
> > This should land on mozilla-1.9.2 and mozilla-central, I guess?
> Only mozilla-central. The change in bug 601913 only landed on l10n-central.

Agreed, we'd remove termiadur for 3.6.x -> 3.6.x+1 updates if it lands on 1.9.2.

Comment 3

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 504680 [details] [diff] [review]
[checked in] Adding termiadu.xml to removed-files.in

Looks fine to me, and seems unlikely that any other locale is using a welsh-english translation.

Comment 4

[David Chan]

Hi, it should be "termiadur.xml" (with an "r" before the dot). The text in the attachment looks correct to me so I presume that's all that matters, but I just wanted to check. Thanks!

Comment 5

[Seth Bindernagel]

(In reply to comment #4)
> Hi, it should be "termiadur.xml" (with an "r" before the dot). The text in the
> attachment looks correct to me so I presume that's all that matters, but I just
> wanted to check. Thanks!

Got it...small typo in the patch description, but you are right, it's correctly spelled in the remove-files.in patch.

Comment 6

[Seth Bindernagel]

I don't think I have hg access to mozilla-central.  Can Pike or nrthomas check in this patch?  Thanks!

Comment 7

[Axel Hecht [:Pike]]

You'll need to hunt for blocking status for the bug or approval for the patch before landing.

Comment 8

[Johnathan Nightingale [:johnath]]

Comment on attachment 504680 [details] [diff] [review]
[checked in] Adding termiadu.xml to removed-files.in

Approved for 2.0 landing.

Comment 9

[Nick Thomas [:nthomas] (UTC+12)]

Fixing up summary to match the effect the patch will have.

Comment 10

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 504680 [details] [diff] [review]
[checked in] Adding termiadu.xml to removed-files.in

http://hg.mozilla.org/mozilla-central/rev/6b5a47683b88