Closed Bug 626617 Opened 13 years ago Closed 13 years ago

Remove Termiadur search plug-in on major update to 4.0

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: sethb, Unassigned)

References

Details

(Keywords: productization)

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #538570 +++

Doing a major update from Welsh 3.6.x will not remove the searchplugins/termiadur.xml file. Attached is a patch to browser/installer/removed-files.in that should fix that (if I understand it correctly). Requesting review from nthomas.

This should land on mozilla-1.9.2 and mozilla-central, I guess?
Attachment #504680 - Flags: review?
Attachment #504680 - Flags: review? → review?(nrthomas)
(In reply to comment #0)
 
> This should land on mozilla-1.9.2 and mozilla-central, I guess?

Only mozilla-central. The change in bug 601913 only landed on l10n-central.
(In reply to comment #1)
> (In reply to comment #0)
> > This should land on mozilla-1.9.2 and mozilla-central, I guess?
> Only mozilla-central. The change in bug 601913 only landed on l10n-central.

Agreed, we'd remove termiadur for 3.6.x -> 3.6.x+1 updates if it lands on 1.9.2.
Blocks: 601913
Comment on attachment 504680 [details] [diff] [review]
[checked in] Adding termiadu.xml to removed-files.in

Looks fine to me, and seems unlikely that any other locale is using a welsh-english translation.
Attachment #504680 - Flags: review?(nrthomas) → review+
Hi, it should be "termiadur.xml" (with an "r" before the dot). The text in the attachment looks correct to me so I presume that's all that matters, but I just wanted to check. Thanks!
(In reply to comment #4)
> Hi, it should be "termiadur.xml" (with an "r" before the dot). The text in the
> attachment looks correct to me so I presume that's all that matters, but I just
> wanted to check. Thanks!

Got it...small typo in the patch description, but you are right, it's correctly spelled in the remove-files.in patch.
I don't think I have hg access to mozilla-central.  Can Pike or nrthomas check in this patch?  Thanks!
You'll need to hunt for blocking status for the bug or approval for the patch before landing.
Comment on attachment 504680 [details] [diff] [review]
[checked in] Adding termiadu.xml to removed-files.in

Approved for 2.0 landing.
Attachment #504680 - Flags: approval2.0+
Fixing up summary to match the effect the patch will have.
Summary: Remove Termiadur search plug-in on major update from 3.6.x → Remove Termiadur search plug-in on major update to 4.0
Comment on attachment 504680 [details] [diff] [review]
[checked in] Adding termiadu.xml to removed-files.in

http://hg.mozilla.org/mozilla-central/rev/6b5a47683b88
Attachment #504680 - Attachment description: Adding termiadu.xml to removed-files.in → [checked in] Adding termiadu.xml to removed-files.in
Blocks: FF2SM
Version: unspecified → Trunk
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
No longer blocks: FF2SM
Component: Build Config → General
Product: Firefox → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: