626632 - nsFilePicker is broken in qt desktop

Status: RESOLVED FIXED

(Core Graveyard :: Widget: Qt, defect)

Description

[Tatiana Meshkova (:tatiana)]

Attachment: broken_file_dialog.png

Open qt desktop Firefox build

File -> Open File

EXPECTED:
file dialog

ACTUAL:
broken_file_dialog.png

Comment 1

[Tatiana Meshkova (:tatiana)]

Attachment: patch

I don't see any reason to embed QFileDialog with QGraphicsProxyWidget creature

Comment 2

[Oleg Romashin (:romaxa)]

Comment on attachment 504698 [details] [diff] [review]
patch


>+    MozQWidget *parentMozWidget = static_cast<MozQWidget*>(parent->GetNativeData(NS_NATIVE_WIDGET));
GetNativeData may return null...
check for null, add NS_WARNING and set parentWidget = 0 if parentMozWidget == null
>+    QWidget *parentWidget = parentMozWidget->getReceiver()->GetViewWidget();
>+
>-    }
>+    mDialog = new QFileDialog(parentWidget, QString::fromUtf16(str.get()));
>

Comment 3

[Tatiana Meshkova (:tatiana)]

Attachment: patch v2

Comment 4

[Oleg Romashin (:romaxa)]

Comment on attachment 504709 [details] [diff] [review]
patch v2

By checking different implementations, I noticed that all other ports are creating Dialogs in ::Show function and in ::InitNative function it is remembering parent, title...

Don't know exactly why it is done this way, but probably it make sense for Qt port do similar implementation...

Comment 5

[Oleg Romashin (:romaxa)]

http://hg.mozilla.org/mozilla-central/rev/3a9a6b749df6