626669 - Dont show "Installing Libraries" message on Fennec splash screen every time

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aaron Train [:aaronmt]]

Currently when starting Fennec, one will see the message "Installing Libraries" and then "Loading". The installing libraries process should just be part of the "Loading" message and is not really necessary or needed for the end-user.

Comment 1

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: patch

on devices with less than 150MB free, we'll never actually write the libraries out to disk so its wrong to show this message.

Comment 2

[Matt Brubeck (:mbrubeck)]

Comment on attachment 504811 [details] [diff] [review]
patch

r=mbrubeck.  One nit, but you can decide whether it's worth fixing:

>+++ b/embedding/android/GeckoApp.java
>+        if (GeckoAppShell.sCacheFile == null)
>+            GeckoAppShell.sCacheFile = getCacheDir();
>+        File libxulFile = new File(GeckoAppShell.sCacheFile, "libxul.so");
>+        if (GeckoAppShell.sFreeSpace == -1) {
>+            StatFs cacheStats = new StatFs(GeckoAppShell.sCacheFile.getPath());
>+            GeckoAppShell.sFreeSpace = cacheStats.getFreeBlocks() * 
>+                cacheStats.getBlockSize();
>+        }

>+++ b/embedding/android/GeckoAppShell.java
>+        if (sCacheFile == null)
>+            sCacheFile = GeckoApp.mAppContext.getCacheDir();
>+        GeckoAppShell.putenv("CACHE_PATH=" + sCacheFile.getPath());
> 
>         // gingerbread introduces File.getUsableSpace(). We should use that.
>+        if (sFreeSpace == -1) {
>+            StatFs cacheStats = new StatFs(sCacheFile.getPath());
>+            sFreeSpace = cacheStats.getFreeBlocks() * 
>+                cacheStats.getBlockSize();
>+        }

Could we put the duplicate code into GeckoAppShell method(s)?  Especially since this fix depends on the logic staying exactly the same in both of these cases.

I'm thinking of methods like getCacheFile(), shouldExtractLibraries(), and shouldRemoveLibraries().  Then sCacheFile, sFreeSpace, and the constants could remain private.

Comment 3

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: patch

that's enough of a change that I'll re-request review

Comment 4

[Brad Lassey [:blassey] (use needinfo?)]

pushed http://hg.mozilla.org/mozilla-central/rev/681b436e1feb

Comment 5

[ahoza]

I can still see "Installing libraries" (for 1 second or less) on Samsung Galaxy S. 
Steps:

1. Uninstall older version (if available)
2. Install the build using adb tool (my device is not rooted, I cannot install it otherwise)
3. Start Fennec.

Comment 6

[Brad Lassey [:blassey] (use needinfo?)]

the point is to not show the "installing libraries" on every boot for devices that don't have enough memory for us to install the libraries

Comment 7

[Andreea Pod]

Verified fixed on build: Mozilla /5.0 (Android;Linux armv7l;rv:6.0a1) Gecko/20110512 Firefox/6.0a1 Fennec/6.0a1 
Device: LG Optimus 2X (Android 2.2)