62680 - [BeOS] keyboard input implemented, some fix on nsWindow

Status: VERIFIED FIXED

(Core :: XUL, defect, P3)

Description

[Makoto Hamanaka]

Currently, keyboard input is almost not working on BeOS, because of poor 
implementation. I implemented full keyboard input function on BeOS widget (nsWindow).
And also, I fixed some bugs on BeOS widget code. I'll attach a patch.

[implemented fuction]
1. Keyboard input

[other fixed bugs]
1. Some dialogs does not appear : fix nsWindow::StandardWindowCreate()
   and nsWindow::Show()
2. Popup menus in HTML pages appears at wrong location : fix nsWindow::Move()
3. Multi-byte string was not allowed on the title bar : fix nsWindow::SetTitle()

[affected files]
widget/src/beos/nsWindow.cpp : implement keyboard input, fix some bugs
widget/src/beos/nsWindow.h
widget/src/beos/nsTextWidget.cpp  :  fix KeyDown()/KeyUp() implementation to meet nsWindow
gfx/src/beos/nsRenderingContextBeOS.cpp : fix InvertRect() to show caret

[notes]
Char code and virtual key code are passed to XP event handling from nsWindow.
In the current implementation in attached patch, char code is retrieved from 'bytes' 
of KeyDown(), which indicates input char code translated by BeOS in the form of UTF-8.
And virtual key code is retrieved from 'key' member on the current BMessage, which 
indicates the position of the key which pressed or released. I think this is sufficient.

[about i18n]
I tested to input some texts in japanese and it was OK.
Though, 'in-line translation' fuction is not implemented, currently.

[focus issue]
I implemented to handle focus but it seems to wrongly behaves sometimes.

ex) When you input URL on the URL form on top of the Mozilla Window, 
if you click on the URL form and leave the mouse cursor inside the URL 
form for a moment, a tooltip will appear and deprive the focus from the URL form.

Comment 1

[Makoto Hamanaka]

Attachment: patch to nsWindow.cpp nsWindow.h nsTextWidget.cpp nsRenderingContextBeOS.cpp

Comment 2

[Yannick Koehler]

I need a reviewer on this to verify that those files won't affect other builds 
than BeOS.  I will then proceed with review on BeOS.

Danm?

Comment 3

[timeless]

Tabs :-( all files are in src/beos/ :-)

Comment 4

[cls]

Patch has been checked in.

Comment 5

[Yannick Koehler]

cls you've apply that patch also?  (why it's still open? should we mark it as 
resolve/fixed?)

Comment 6

[cls]

Yes, it should be marked fixed.  I got distracted and forgot to change it earlier.

Comment 7

[Kai Lahmann (is there, where MNG is)]

v