62703 - Mail Compose: Need mnemonics for "Attachments" and "Subject"

Status: VERIFIED FIXED

(MailNews Core :: Composition, defect, P3)

Description

[jglick]

Mail Compose: Need mnemonics for "Attachments" and "Subject". 4.x parity. 
Mnemonics to directly access the Attachments or Subject text fields.

Suggest "A" underlined for Attachments and "S" underlined for Subject.

"From" mnemonic was mentioned in bug 31250.

Comment 1

[jglick]

Add mail3 keyword. Reassign to varada.

Comment 2

[scottputterman]

marking nsbeta1+ and moving to mozilla0.8

Comment 3

[Håkan Waara]

Attachment: [Patch] adds "s" as subject accesskey, and "a" for attachments.

Comment 4

[timeless]

r=timeless

Comment 5

[Alec Flett]

ok, looks good. sr=alecf

Comment 6

[timeless]

fix checked in

Comment 7

[scottputterman]

How do I make the access key work?

Comment 8

[Matthew T (active 1999-2002)]

Windows with menus shouldn't have accesskeys for items other than menus. 
Shortcuts (such as Ctrl+Tab) are fine, but accesskeys (for items other than 
menus) should only be used in dialogs.

Comment 9

[timeless]

Windows 2000 Find has accesskeys for the sidebar and menus in the window.  If 
the accesskeys don't work, file a bug on hyatt or someone else.

Comment 10

[[e-mail]]

Marking Verified

OS: Win2k SP1
Moz Build: 2001012820 Win2k Talkback
User Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; m18) Gecko/20010128

Comment 11

[Ninoschka Baca]

Build 2001-01-2908: Linux RH 6.2
Modern and Classic themes both have the mnemonics, as stated before, don't seem
to work.

Comment 12

[Jesse Ruderman]

Reopening because the fix adds mnemonics for the labels, but doesn't hook the 
labels up to the things they're next to.  As a result, the mnemonics don't 
actually work, and clicking on the labels doesn't do anything.

Here's an example of how to hook a label up to a textfield... hopefully this 
also works for the "attachments" control: 
http://lxr.mozilla.org/seamonkey/source/xpfe/components/prefwindow/resources/con﷒0﷓

Comment 13

[scottputterman]

moving to mozilla0.9. If someone gets this in before that that will be great.
But not getting this in wouldn't hold up mozilla0.8

Comment 14

[scottputterman]

marking nsbeta1- and moving to future milestone. 

Comment 15

[Jesse Ruderman]

The reason the mnemonics doesn't work could be bug 959 (so the original patch 
might have been correct).

Comment 16

[[e-mail]]

I can do this.

Comment 17

[[e-mail]]

Attachment: Patch to add control attributes to link up access keys

Comment 18

[[e-mail]]

This is such a simple patch I hope it lands in time for 1.0, especially as the
labels already appear to have the access keys defined, they just don't work yet.

I noticed that "From:" doesn't have an access key, does it need one? Which one?

Comment 19

[Håkan Waara]

r=hwaara for attachment 80710 [details] [diff] [review]

Comment 20

[jglick]

F_r_om

http://www.mozilla.org/mailnews/specs/compose/images/Compose1.gif

Comment 21

[[e-mail]]

Attachment: Also Fix From

I also fixed Håkan's name and the case of the access keys to match the labels.

Comment 22

[timeless]

Comment on attachment 80791 [details] [diff] [review]
Also Fix From

r=timeless

[e-mail]: please update the spec to include thw Window menu and to 
have &Attachments instead of Att&achments :-)

Comment 23

[Håkan Waara]

r=hwaara too, fwiw.

Comment 24

[Alec Flett]

Comment on attachment 80791 [details] [diff] [review]
Also Fix From

sr=alecf

Comment 25

[Alec Flett]

Comment on attachment 80791 [details] [diff] [review]
Also Fix From

sr=alecf but I want to see module owner review on this one. (removing hwaara's
review so we can get this)

Comment 26

[[e-mail]]

alecf, r=timeless was good enough for the other patch, why not this one? Bah.

Comment 27

[Jean-Francois Ducarroz]

Comment on attachment 80791 [details] [diff] [review]
Also Fix From

looks good. R=ducarroz

Comment 28

[Christian :Biesinger (don't email me, ping me on IRC)]

checked in on trunk

Comment 29

[Christian :Biesinger (don't email me, ping me on IRC)]

*** Bug 31250 has been marked as a duplicate of this bug. ***

Comment 30

[Asa Dotzler [:asa]]

Comment on attachment 80791 [details] [diff] [review]
Also Fix From

a=asa (on behalf of drivers) for checkin to the 1.0 branch

Comment 31

[Bartosz Wucke]

Removing "verifyme" keyword. (verified already)

Comment 32

[[e-mail]]

Fixed ages ago - [e-mail] checked the patch in for me.

Comment 33

[laurel]

marking verified, OK In current commercial trunk

Comment 34

[(not reading, please use [e-mail] instead)]

fyi, this caused a regression.

"alt-a" on linux is select all.

see bug #180950