Add-ons are using wrong font family and text color

RESOLVED FIXED

Status

P2
normal
RESOLVED FIXED
8 years ago
6 years ago

People

(Reporter: limi, Assigned: zer0)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

It looks like add-ons created using the Jetpack SDK are using a serif font as their default, making elements added to the add-ons bar look out of place.

To ensure consistent look across Win7/Vista, XP and OS X respectively, the font should be:

font-family: "Segoe UI", Tahoma, "Lucida Grande", sans-serif;

You can see this in the Hard Blocker add-on (although he might have added CSS to correct this by the time I have filed this bug ;):

https://addons.mozilla.org/en-US/firefox/addon/hard-blockers-counter/

Not sure if there's a standard on Linux, but I assume sans-serif may take care of that.
Created attachment 505206 [details]
Screenshot showing the serif font in add-ons bar of the OS X window, which looks bad

Added screenshot from OS X to illustrate.
The text color isn't inherited from the toolbar either. Can be tested with a persona with a text color other than black.
OS: Mac OS X → All
Hardware: x86 → All
Priority: -- → P2
Target Milestone: --- → 1.0
Summary: Add-ons are using wrong font family → Add-ons are using wrong font family and text color
(automatic reprioritization of 1.0 bugs)
Priority: P2 → P1
Target Milestone: 1.0 → 1.1
(Assignee)

Updated

7 years ago
Assignee: nobody → zer0
Priority: P1 → P2

Comment 5

7 years ago
Instead of hardcoding anything, can these values be picked up from the application itself?
(Pushing all open bugs to the --- milestone for the new triage system)
Target Milestone: 1.1 → ---
(Assignee)

Comment 7

6 years ago
Fixed by dglol in this commit: https://github.com/mozilla/addon-sdk/commit/da8fc9b60a6ecc668194d15d5d624587e3c18208
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.