627189 - Add-ons are using wrong font family and text color

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P2)

Description

[Alex Limi (:limi) — Firefox UX Team]

It looks like add-ons created using the Jetpack SDK are using a serif font as their default, making elements added to the add-ons bar look out of place.

To ensure consistent look across Win7/Vista, XP and OS X respectively, the font should be:

font-family: "Segoe UI", Tahoma, "Lucida Grande", sans-serif;

You can see this in the Hard Blocker add-on (although he might have added CSS to correct this by the time I have filed this bug ;):

https://addons.mozilla.org/en-US/firefox/addon/hard-blockers-counter/

Not sure if there's a standard on Linux, but I assume sans-serif may take care of that.

Comment 1

[Zibi Braniecki [:zbraniecki][:gandalf]]

you can just test the revision 256: https://builder.addons.mozilla.org/addon/1000065/revision/256/

Comment 2

[Alex Limi (:limi) — Firefox UX Team]

Attachment: Screenshot showing the serif font in add-ons bar of the OS X window, which looks bad

Added screenshot from OS X to illustrate.

Comment 3

[Dão Gottwald [:dao]]

The text color isn't inherited from the toolbar either. Can be tested with a persona with a text color other than black.

Comment 4

[Myk Melez [:myk] [@mykmelez]]

(automatic reprioritization of 1.0 bugs)

Comment 5

[alanjstr]

Instead of hardcoding anything, can these values be picked up from the application itself?

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

(Pushing all open bugs to the --- milestone for the new triage system)

Comment 7

[Matteo Ferretti [:zer0] [:matteo]]

Fixed by dglol in this commit: https://github.com/mozilla/addon-sdk/commit/da8fc9b60a6ecc668194d15d5d624587e3c18208