Status

defect
RESOLVED FIXED
9 years ago
5 years ago

People

(Reporter: khuey, Assigned: Mitch)

Tracking

(Blocks 1 bug)

Trunk
Future
All
BeOS
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: fixed-in-bs)

Attachments

(18 attachments, 3 obsolete attachments)

304.16 KB, patch
Biesinger
: review+
Details | Diff | Splinter Review
10.98 KB, patch
Gavin
: review+
Details | Diff | Splinter Review
19.13 KB, patch
Biesinger
: review+
Details | Diff | Splinter Review
gfx
30.27 KB, patch
roc
: review+
Biesinger
: review+
Details | Diff | Splinter Review
js
15.00 KB, patch
jorendorff
: review+
Details | Diff | Splinter Review
41.07 KB, patch
shaver
: review+
Details | Diff | Splinter Review
30.36 KB, patch
neil
: review+
Details | Diff | Splinter Review
2.78 KB, patch
Biesinger
: review+
Details | Diff | Splinter Review
8.08 KB, patch
smontagu
: review+
Details | Diff | Splinter Review
20.56 KB, patch
joe
: review+
Details | Diff | Splinter Review
5.45 KB, patch
dwitte
: review+
Details | Diff | Splinter Review
db
3.91 KB, patch
shaver
: review+
Details | Diff | Splinter Review
10.10 KB, patch
jaas
: review+
Details | Diff | Splinter Review
3.54 KB, patch
taras.mozilla
: review+
Details | Diff | Splinter Review
rdf
7.14 KB, patch
axel
: review+
Details | Diff | Splinter Review
3.06 KB, patch
mfinkle
: review+
Details | Diff | Splinter Review
865 bytes, patch
roc
: review+
Details | Diff | Splinter Review
11.08 KB, patch
khuey
: review+
Details | Diff | Splinter Review
After we ship 2.0, I'd like to rm -r widget/src/beos.  Roc owns widget/ and biesi is the owner of record for widget/src/beos, so CCing them both in case they object for some reason.
Yeah, realistically, this code isn't working now and probably won't in the future. People can revive it from the hg history if they want to work on it again.
After this lands, we should maybe WONTFIX all remaining bugs with [beos] in the title or platform fields.
Zack, I just happened to notice your tryserver push, where you're moving some
files. Could you please not do that. Hg bug http://mercurial.selenic.com/bts/issue1576 should be fixed before file moves :(
Assignee

Updated

9 years ago
Assignee: nobody → mitchell.field
Status: NEW → ASSIGNED
Version: unspecified → Trunk
Assignee

Comment 5

9 years ago
Posted patch widgetSplinter Review
Attachment #507430 - Flags: review?(cbiesinger)
Assignee

Comment 6

9 years ago
Posted patch browserSplinter Review
Attachment #507436 - Flags: review?(gavin.sharp)
Assignee

Comment 7

9 years ago
Posted patch docshellSplinter Review
Attachment #507437 - Flags: review?(jst)
Assignee

Comment 8

9 years ago
Posted patch gfxSplinter Review
Attachment #507442 - Flags: review?(roc)
Assignee

Comment 9

9 years ago
Posted patch layout (obsolete) — Splinter Review
Attachment #507443 - Flags: review?(roc)
Assignee

Comment 10

9 years ago
Comment on attachment 507443 [details] [diff] [review]
layout

Disregard this. Other changes crept in.
Attachment #507443 - Attachment is obsolete: true
Attachment #507443 - Flags: review?(roc)
Assignee

Comment 11

9 years ago
Posted patch jsSplinter Review
Attachment #507450 - Flags: review?(jorendorff)
Assignee

Comment 12

9 years ago
Posted patch xpcomSplinter Review
Attachment #507453 - Flags: review?(shaver)
Assignee

Comment 13

9 years ago
Posted patch toolkitSplinter Review
Attachment #507456 - Flags: review?(neil)
Assignee

Comment 14

9 years ago
Posted patch netwerkSplinter Review
Attachment #507458 - Flags: review?(cbiesinger)
Attachment #507456 - Flags: review?(neil) → review+
Assignee

Comment 15

9 years ago
Posted patch intlSplinter Review
Attachment #507463 - Flags: review?(smontagu)
Assignee

Comment 16

9 years ago
Posted patch libpr0nSplinter Review
Attachment #507467 - Flags: review?(joe)
Assignee

Comment 17

9 years ago
Posted patch libprefSplinter Review
Attachment #507470 - Flags: review?
Assignee

Updated

9 years ago
Attachment #507470 - Flags: review? → review?(dwitte)
Assignee

Comment 18

9 years ago
Posted patch plugin (obsolete) — Splinter Review
Attachment #507474 - Flags: review?(joshmoz)

Comment 19

9 years ago
Comment on attachment 507474 [details] [diff] [review]
plugin

>diff --git a/modules/plugin/base/src/Makefile.in b/modules/plugin/base/src/Makefile.in

>-ifeq ($(OS_ARCH), BeOS)
>-	CPPSRCS += nsPluginsDirBeOS.cpp
>-	CPPSRCS += nsPluginNativeWindow.cpp
>-else
> ifneq (,$(filter WINNT WINCE,$(OS_ARCH)))
> 	CPPSRCS += nsPluginsDirWin.cpp

I think you're forgetting to remove the matching "endif".
Attachment #507474 - Flags: review?(joshmoz) → review-
Assignee

Comment 20

9 years ago
Posted patch dbSplinter Review
No-one cares about Mork so I chose a reviewer for Firefox in general.
Attachment #507484 - Flags: review?(shaver)
Assignee

Comment 21

9 years ago
Posted patch pluginSplinter Review
Attachment #507474 - Attachment is obsolete: true
Attachment #507490 - Flags: review?(joshmoz)

Updated

9 years ago
Attachment #507490 - Flags: review?(joshmoz) → review+
Attachment #507436 - Flags: review?(gavin.sharp) → review+
Assignee

Comment 22

9 years ago
Posted patch libjarSplinter Review
Attachment #507497 - Flags: review?(tglek)
Attachment #507430 - Flags: review?(cbiesinger) → review+
Attachment #507458 - Flags: review?(cbiesinger) → review+
Assignee

Updated

9 years ago
Attachment #507484 - Flags: review?(shaver) → review?(gavin.sharp)
Assignee

Comment 23

9 years ago
Posted patch rdfSplinter Review
Attachment #507502 - Flags: review?(axel)

Updated

9 years ago
Attachment #507502 - Flags: review?(axel) → review+
Assignee

Comment 24

9 years ago
Posted patch relic (obsolete) — Splinter Review
Attachment #507506 - Flags: review?
Assignee

Comment 25

9 years ago
Posted patch xulrunnerSplinter Review
Attachment #507512 - Flags: review?(mark.finkle)
Attachment #507512 - Flags: review?(mark.finkle) → review+

Updated

9 years ago
Attachment #507497 - Flags: review?(tglek) → review+
Assignee

Comment 26

9 years ago
Posted patch layoutSplinter Review
Attachment #507516 - Flags: review?(roc)
Assignee

Comment 27

9 years ago
Posted patch configSplinter Review
Attachment #507517 - Flags: review?(khuey)
Comment on attachment 507484 [details] [diff] [review]
db

Can we just remove mork entirely, or move it to Thunderbird?  I guess that's for another bug.
Attachment #507484 - Flags: review?(gavin.sharp) → review+
We still link morkreader into Firefox.  After 2.0 ships I'll revive my patch to remove that and then we can move mork elsewhere.
Assignee

Comment 30

9 years ago
Comment on attachment 507506 [details] [diff] [review]
relic

Files affected by this patch have coincidentally been deleted from mozilla-central.
Attachment #507506 - Attachment is obsolete: true
Attachment #507506 - Flags: review?(gerv)
Blocks: 629500

Comment 31

9 years ago
Comment on attachment 507470 [details] [diff] [review]
libpref

r=dwitte
Attachment #507470 - Flags: review?(dwitte) → review+
Comment on attachment 507517 [details] [diff] [review]
config

Presumably there should be an autoconf.mk.in removal for the AC_SUBST you're removing?
Attachment #507517 - Flags: review?(khuey) → review+
Attachment #507450 - Flags: review?(jorendorff) → review+
Comment on attachment 507467 [details] [diff] [review]
libpr0n

r=me presuming it passes try
Attachment #507467 - Flags: review?(joe) → review+
Attachment #507463 - Flags: review?(smontagu) → review+
Assignee

Updated

8 years ago
Whiteboard: fixed-in-bs

Updated

7 years ago
Blocks: 808399
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.