Closed Bug 627277 Opened 10 years ago Closed 10 years ago

rm -r widget/src/beos

Categories

(Core Graveyard :: Widget: BeOS, defect)

All
BeOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Future

People

(Reporter: khuey, Assigned: Mitch)

References

(Blocks 1 open bug)

Details

(Whiteboard: fixed-in-bs)

Attachments

(18 files, 3 obsolete files)

304.16 KB, patch
Biesinger
: review+
Details | Diff | Splinter Review
10.98 KB, patch
Gavin
: review+
Details | Diff | Splinter Review
19.13 KB, patch
Biesinger
: review+
Details | Diff | Splinter Review
gfx
30.27 KB, patch
roc
: review+
Biesinger
: review+
Details | Diff | Splinter Review
js
15.00 KB, patch
jorendorff
: review+
Details | Diff | Splinter Review
41.07 KB, patch
shaver
: review+
Details | Diff | Splinter Review
30.36 KB, patch
neil
: review+
Details | Diff | Splinter Review
2.78 KB, patch
Biesinger
: review+
Details | Diff | Splinter Review
8.08 KB, patch
smontagu
: review+
Details | Diff | Splinter Review
20.56 KB, patch
joe
: review+
Details | Diff | Splinter Review
5.45 KB, patch
dwitte
: review+
Details | Diff | Splinter Review
db
3.91 KB, patch
shaver
: review+
Details | Diff | Splinter Review
10.10 KB, patch
jaas
: review+
Details | Diff | Splinter Review
3.54 KB, patch
taras.mozilla
: review+
Details | Diff | Splinter Review
rdf
7.14 KB, patch
axel
: review+
Details | Diff | Splinter Review
3.06 KB, patch
mfinkle
: review+
Details | Diff | Splinter Review
865 bytes, patch
roc
: review+
Details | Diff | Splinter Review
11.08 KB, patch
khuey
: review+
Details | Diff | Splinter Review
After we ship 2.0, I'd like to rm -r widget/src/beos.  Roc owns widget/ and biesi is the owner of record for widget/src/beos, so CCing them both in case they object for some reason.
Yeah, realistically, this code isn't working now and probably won't in the future. People can revive it from the hg history if they want to work on it again.
After this lands, we should maybe WONTFIX all remaining bugs with [beos] in the title or platform fields.
Zack, I just happened to notice your tryserver push, where you're moving some
files. Could you please not do that. Hg bug http://mercurial.selenic.com/bts/issue1576 should be fixed before file moves :(
Assignee: nobody → mitchell.field
Status: NEW → ASSIGNED
Version: unspecified → Trunk
Attached patch widgetSplinter Review
Attachment #507430 - Flags: review?(cbiesinger)
Attached patch browserSplinter Review
Attachment #507436 - Flags: review?(gavin.sharp)
Attached patch docshellSplinter Review
Attachment #507437 - Flags: review?(jst)
Attached patch gfxSplinter Review
Attachment #507442 - Flags: review?(roc)
Attached patch layout (obsolete) — Splinter Review
Attachment #507443 - Flags: review?(roc)
Comment on attachment 507443 [details] [diff] [review]
layout

Disregard this. Other changes crept in.
Attachment #507443 - Attachment is obsolete: true
Attachment #507443 - Flags: review?(roc)
Attached patch jsSplinter Review
Attachment #507450 - Flags: review?(jorendorff)
Attached patch xpcomSplinter Review
Attachment #507453 - Flags: review?(shaver)
Attached patch toolkitSplinter Review
Attachment #507456 - Flags: review?(neil)
Attached patch netwerkSplinter Review
Attachment #507458 - Flags: review?(cbiesinger)
Attachment #507456 - Flags: review?(neil) → review+
Attached patch intlSplinter Review
Attachment #507463 - Flags: review?(smontagu)
Attached patch libpr0nSplinter Review
Attachment #507467 - Flags: review?(joe)
Attached patch libprefSplinter Review
Attachment #507470 - Flags: review?
Attachment #507470 - Flags: review? → review?(dwitte)
Attached patch plugin (obsolete) — Splinter Review
Attachment #507474 - Flags: review?(joshmoz)
Comment on attachment 507474 [details] [diff] [review]
plugin

>diff --git a/modules/plugin/base/src/Makefile.in b/modules/plugin/base/src/Makefile.in

>-ifeq ($(OS_ARCH), BeOS)
>-	CPPSRCS += nsPluginsDirBeOS.cpp
>-	CPPSRCS += nsPluginNativeWindow.cpp
>-else
> ifneq (,$(filter WINNT WINCE,$(OS_ARCH)))
> 	CPPSRCS += nsPluginsDirWin.cpp

I think you're forgetting to remove the matching "endif".
Attachment #507474 - Flags: review?(joshmoz) → review-
Attached patch dbSplinter Review
No-one cares about Mork so I chose a reviewer for Firefox in general.
Attachment #507484 - Flags: review?(shaver)
Attached patch pluginSplinter Review
Attachment #507474 - Attachment is obsolete: true
Attachment #507490 - Flags: review?(joshmoz)
Attachment #507490 - Flags: review?(joshmoz) → review+
Attachment #507436 - Flags: review?(gavin.sharp) → review+
Attached patch libjarSplinter Review
Attachment #507497 - Flags: review?(tglek)
Attachment #507430 - Flags: review?(cbiesinger) → review+
Attachment #507458 - Flags: review?(cbiesinger) → review+
Attachment #507484 - Flags: review?(shaver) → review?(gavin.sharp)
Attachment #507437 - Flags: review?(jst) → review+
Attached patch rdfSplinter Review
Attachment #507502 - Flags: review?(axel)
Attachment #507502 - Flags: review?(axel) → review+
Attached patch relic (obsolete) — Splinter Review
Attachment #507506 - Flags: review?
Attachment #507506 - Flags: review? → review?(gerv)
Attached patch xulrunnerSplinter Review
Attachment #507512 - Flags: review?(mark.finkle)
Attachment #507512 - Flags: review?(mark.finkle) → review+
Attachment #507497 - Flags: review?(tglek) → review+
Attached patch layoutSplinter Review
Attachment #507516 - Flags: review?(roc)
Attached patch configSplinter Review
Attachment #507517 - Flags: review?(khuey)
Comment on attachment 507484 [details] [diff] [review]
db

Can we just remove mork entirely, or move it to Thunderbird?  I guess that's for another bug.
Attachment #507484 - Flags: review?(gavin.sharp) → review+
We still link morkreader into Firefox.  After 2.0 ships I'll revive my patch to remove that and then we can move mork elsewhere.
Comment on attachment 507506 [details] [diff] [review]
relic

Files affected by this patch have coincidentally been deleted from mozilla-central.
Attachment #507506 - Attachment is obsolete: true
Attachment #507506 - Flags: review?(gerv)
Blocks: 629500
Comment on attachment 507470 [details] [diff] [review]
libpref

r=dwitte
Attachment #507470 - Flags: review?(dwitte) → review+
Comment on attachment 507517 [details] [diff] [review]
config

Presumably there should be an autoconf.mk.in removal for the AC_SUBST you're removing?
Attachment #507517 - Flags: review?(khuey) → review+
Attachment #507450 - Flags: review?(jorendorff) → review+
Comment on attachment 507467 [details] [diff] [review]
libpr0n

r=me presuming it passes try
Attachment #507467 - Flags: review?(joe) → review+
Attachment #507463 - Flags: review?(smontagu) → review+
Whiteboard: fixed-in-bs
Blocks: 808399
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.