627277 - rm -r widget/src/beos

Status: RESOLVED FIXED

(Core Graveyard :: Widget: BeOS, defect)

Description

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

After we ship 2.0, I'd like to rm -r widget/src/beos.  Roc owns widget/ and biesi is the owner of record for widget/src/beos, so CCing them both in case they object for some reason.

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

Yeah, realistically, this code isn't working now and probably won't in the future. People can revive it from the hg history if they want to work on it again.

Comment 2

[Zack Weinberg (:zwol)]

After this lands, we should maybe WONTFIX all remaining bugs with [beos] in the title or platform fields.

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

WFM.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Zack, I just happened to notice your tryserver push, where you're moving some
files. Could you please not do that. Hg bug http://mercurial.selenic.com/bts/issue1576 should be fixed before file moves :(

Comment 5

[Mitchell Field [:Mitch]]

Attachment: widget

Comment 6

[Mitchell Field [:Mitch]]

Attachment: browser

Comment 7

[Mitchell Field [:Mitch]]

Attachment: docshell

Comment 8

[Mitchell Field [:Mitch]]

Attachment: gfx

Comment 9

[Mitchell Field [:Mitch]]

Attachment: layout

Comment 10

[Mitchell Field [:Mitch]]

Comment on attachment 507443 [details] [diff] [review]
layout

Disregard this. Other changes crept in.

Comment 11

[Mitchell Field [:Mitch]]

Attachment: js

Comment 12

[Mitchell Field [:Mitch]]

Attachment: xpcom

Comment 13

[Mitchell Field [:Mitch]]

Attachment: toolkit

Comment 14

[Mitchell Field [:Mitch]]

Attachment: netwerk

Comment 15

[Mitchell Field [:Mitch]]

Attachment: intl

Comment 16

[Mitchell Field [:Mitch]]

Attachment: libpr0n

Comment 17

[Mitchell Field [:Mitch]]

Attachment: libpref

Comment 18

[Mitchell Field [:Mitch]]

Attachment: plugin

Comment 19

[Josh Aas]

Comment on attachment 507474 [details] [diff] [review]
plugin

>diff --git a/modules/plugin/base/src/Makefile.in b/modules/plugin/base/src/Makefile.in

>-ifeq ($(OS_ARCH), BeOS)
>-	CPPSRCS += nsPluginsDirBeOS.cpp
>-	CPPSRCS += nsPluginNativeWindow.cpp
>-else
> ifneq (,$(filter WINNT WINCE,$(OS_ARCH)))
> 	CPPSRCS += nsPluginsDirWin.cpp

I think you're forgetting to remove the matching "endif".

Comment 20

[Mitchell Field [:Mitch]]

Attachment: db

No-one cares about Mork so I chose a reviewer for Firefox in general.

Comment 21

[Mitchell Field [:Mitch]]

Attachment: plugin

Comment 22

[Mitchell Field [:Mitch]]

Attachment: libjar

Comment 23

[Mitchell Field [:Mitch]]

Attachment: rdf

Comment 24

[Mitchell Field [:Mitch]]

Attachment: relic

Comment 25

[Mitchell Field [:Mitch]]

Attachment: xulrunner

Comment 26

[Mitchell Field [:Mitch]]

Attachment: layout

Comment 27

[Mitchell Field [:Mitch]]

Attachment: config

Comment 28

[Mike Shaver (:shaver emeritus)]

Comment on attachment 507484 [details] [diff] [review]
db

Can we just remove mork entirely, or move it to Thunderbird?  I guess that's for another bug.

Comment 29

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

We still link morkreader into Firefox.  After 2.0 ships I'll revive my patch to remove that and then we can move mork elsewhere.

Comment 30

[Mitchell Field [:Mitch]]

Comment on attachment 507506 [details] [diff] [review]
relic

Files affected by this patch have coincidentally been deleted from mozilla-central.

Comment 31

[[e-mail]]

Comment on attachment 507470 [details] [diff] [review]
libpref

r=dwitte

Comment 32

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 507517 [details] [diff] [review]
config

Presumably there should be an autoconf.mk.in removal for the AC_SUBST you're removing?

Comment 33

[Joe Drew (not getting mail)]

Comment on attachment 507467 [details] [diff] [review]
libpr0n

r=me presuming it passes try

Comment 34

[Mike Shaver (:shaver emeritus)]

Comment on attachment 507453 [details] [diff] [review]
xpcom

begone.

Comment 35

[Mitchell Field [:Mitch]]

http://hg.mozilla.org/projects/build-system/rev/1feb4a7c7ca6
http://hg.mozilla.org/projects/build-system/rev/347d38aeaacc
http://hg.mozilla.org/projects/build-system/rev/cd4e66877044
http://hg.mozilla.org/projects/build-system/rev/95f3fcd24cc4
http://hg.mozilla.org/projects/build-system/rev/c05a09d2592e

Comment 36

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

http://hg.mozilla.org/mozilla-central/rev/1feb4a7c7ca6
http://hg.mozilla.org/mozilla-central/rev/347d38aeaacc
http://hg.mozilla.org/mozilla-central/rev/cd4e66877044
http://hg.mozilla.org/mozilla-central/rev/95f3fcd24cc4
http://hg.mozilla.org/mozilla-central/rev/c05a09d2592e