Closed Bug 627324 Opened 13 years ago Closed 13 years ago

Bottom toolbox border interrupts shadow on the sides

Categories

(Firefox :: Theme, defect)

x86
Windows 7
defect
Not set
trivial

Tracking

()

RESOLVED FIXED
Firefox 4.0b11

People

(Reporter: dao, Assigned: dao)

References

Details

(Keywords: polish)

Attachments

(1 file, 1 obsolete file)

Blocks: 624679
Attached patch patch (obsolete) — Splinter Review
Assignee: nobody → dao
Status: NEW → ASSIGNED
Attachment #506106 - Flags: review?(fryn)
Blocks: 626351
Keywords: polish
Comment on attachment 506106 [details] [diff] [review]
patch

Code and appearance look good.

> +  background: ThreeDShadow;

Nit: I think this should be |background-color: ThreeDShadow;|.

r+ with that addressed.
Attachment #506106 - Flags: review?(fryn) → review+
Attached patch patchSplinter Review
Attachment #506106 - Attachment is obsolete: true
Attachment #506117 - Flags: approval2.0?
Attachment #506117 - Flags: review+
Attachment #506117 - Flags: approval2.0? → approval2.0+
Pushed.

http://hg.mozilla.org/mozilla-central/rev/cd10b3f59da4

Dão, is bug 626351 fixed by this too?
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b11
(In reply to comment #4)
> Pushed.
> 
> http://hg.mozilla.org/mozilla-central/rev/cd10b3f59da4
> 
> Dão, is bug 626351 fixed by this too?

I think so.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: