re-enable browser_webconsole_js_input_expansion.js

RESOLVED FIXED in Firefox 6

Status

()

Firefox
Developer Tools
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: rc, Assigned: rc)

Tracking

unspecified
Firefox 6
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [console-2][fixed-in-devtools][merged-to-mozilla-central])

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
from checkin of bug 605621

TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/toolkit/components/console/hudservice/tests/browser/browser_webconsole_js_input_expansion.js | height shrank to original size.

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1295530399.1295531364.8188.gz#err0
(Assignee)

Comment 1

6 years ago
checked in http://hg.mozilla.org/mozilla-central/rev/a9ad814a40e3 to temporarily disable this failing test.

Test seems to only fail on OS X 32 bit.
(Assignee)

Comment 2

6 years ago
try build goes here: http://ftp.mozilla.org/pub/mozilla.org/firefox/tryserver-builds/rcampbell@mozilla.com-764b4c3636c6
(Assignee)

Comment 3

6 years ago
Created attachment 505447 [details] [diff] [review]
[in-devtools]test within 1px

measuring within 1px to allow OS X 32 to pass.
Assignee: nobody → rcampbell
Status: NEW → ASSIGNED
Attachment #505447 - Flags: review?(gavin.sharp)
(Assignee)

Comment 4

6 years ago
any thoughts on this?
(Assignee)

Comment 5

6 years ago
Comment on attachment 505447 [details] [diff] [review]
[in-devtools]test within 1px

requesting feedback.

Also wondering if it's worth adding a "within" test to SimpleTest.js to accommodate these kinds of tests.
Attachment #505447 - Flags: feedback?(pwalton)
(In reply to comment #5)
> Also wondering if it's worth adding a "within" test to SimpleTest.js to
> accommodate these kinds of tests.

Something like is_epsilon(foo, bar, epsilon) might be interesting.
Comment on attachment 505447 [details] [diff] [review]
[in-devtools]test within 1px

Fine by me.
Attachment #505447 - Flags: feedback?(pwalton) → feedback+

Updated

6 years ago
Whiteboard: [console-2]
Attachment #505447 - Flags: review?(gavin.sharp) → review+
(Assignee)

Updated

6 years ago
Whiteboard: [console-2] → [console-2][checkin]
(Assignee)

Updated

6 years ago
Whiteboard: [console-2][checkin] → [console-2][fixed-in-devtools]
(Assignee)

Comment 8

6 years ago
Comment on attachment 505447 [details] [diff] [review]
[in-devtools]test within 1px

http://hg.mozilla.org/projects/devtools/rev/16c139bbe0ca
Attachment #505447 - Attachment description: test within 1px → [in-devtools]test within 1px
(Assignee)

Updated

6 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [console-2][fixed-in-devtools] → [console-2][fixed-in-devtools][merged-to-mozilla-central]
Target Milestone: --- → Firefox 6
(Assignee)

Comment 9

6 years ago
Comment on attachment 505447 [details] [diff] [review]
[in-devtools]test within 1px

http://hg.mozilla.org/mozilla-central/rev/16c139bbe0ca
You need to log in before you can comment on or make changes to this bug.