Closed Bug 627342 Opened 10 years ago Closed 10 years ago

re-enable browser_webconsole_js_input_expansion.js

Categories

(DevTools :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 6

People

(Reporter: rcampbell, Assigned: rcampbell)

Details

(Whiteboard: [console-2][fixed-in-devtools][merged-to-mozilla-central])

Attachments

(1 file)

from checkin of bug 605621

TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/toolkit/components/console/hudservice/tests/browser/browser_webconsole_js_input_expansion.js | height shrank to original size.

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1295530399.1295531364.8188.gz#err0
checked in http://hg.mozilla.org/mozilla-central/rev/a9ad814a40e3 to temporarily disable this failing test.

Test seems to only fail on OS X 32 bit.
measuring within 1px to allow OS X 32 to pass.
Assignee: nobody → rcampbell
Status: NEW → ASSIGNED
Attachment #505447 - Flags: review?(gavin.sharp)
any thoughts on this?
Comment on attachment 505447 [details] [diff] [review]
[in-devtools]test within 1px

requesting feedback.

Also wondering if it's worth adding a "within" test to SimpleTest.js to accommodate these kinds of tests.
Attachment #505447 - Flags: feedback?(pwalton)
(In reply to comment #5)
> Also wondering if it's worth adding a "within" test to SimpleTest.js to
> accommodate these kinds of tests.

Something like is_epsilon(foo, bar, epsilon) might be interesting.
Comment on attachment 505447 [details] [diff] [review]
[in-devtools]test within 1px

Fine by me.
Attachment #505447 - Flags: feedback?(pwalton) → feedback+
Whiteboard: [console-2]
Attachment #505447 - Flags: review?(gavin.sharp) → review+
Whiteboard: [console-2] → [console-2][checkin]
Whiteboard: [console-2][checkin] → [console-2][fixed-in-devtools]
Comment on attachment 505447 [details] [diff] [review]
[in-devtools]test within 1px

http://hg.mozilla.org/projects/devtools/rev/16c139bbe0ca
Attachment #505447 - Attachment description: test within 1px → [in-devtools]test within 1px
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [console-2][fixed-in-devtools] → [console-2][fixed-in-devtools][merged-to-mozilla-central]
Target Milestone: --- → Firefox 6
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.