Last Comment Bug 627455 - Lots of L10n repack failures after omnijar switch
: Lots of L10n repack failures after omnijar switch
Status: RESOLVED FIXED
: regression
Product: SeaMonkey
Classification: Client Software
Component: Build Config (show other bugs)
: Trunk
: All All
: -- normal (vote)
: seamonkey2.1b2
Assigned To: Robert Kaiser
:
:
Mentors:
Depends on:
Blocks: 588067
  Show dependency treegraph
 
Reported: 2011-01-20 11:35 PST by Robert Kaiser
Modified: 2011-01-31 21:09 PST (History)
0 users
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
port missed hunk (877 bytes, patch)
2011-01-20 11:40 PST, Robert Kaiser
bugspam.Callek: review+
Details | Diff | Splinter Review

Description Robert Kaiser 2011-01-20 11:35:30 PST
I tried to make L10n repacks work fine with omni.jar and I mostly have succeeded, but what I didn't look at is repeated L10n repacks for different locales from the same directory structure, which is what our buildbots do. There seems to be a small glitch (missed porting from l10n.mk) that makes those fail.

I *should* have a patch for that, but I'm trying to confirm on a slave right now.
Comment 1 Robert Kaiser 2011-01-20 11:40:09 PST
Created attachment 505475 [details] [diff] [review]
port missed hunk

This ports the missing l10n.mk hunk from http://hg.mozilla.org/mozilla-central/rev/d37b6b337227 to suite/ as we're not using l10n.mk yet. I tested that it works on a slave with the steps our factories are applying.
Comment 2 Robert Kaiser 2011-01-20 12:44:07 PST
Thanks for the fast review, pushed as http://hg.mozilla.org/comm-central/rev/1025dd5f0c49

Note You need to log in before you can comment on or make changes to this bug.