Closed
Bug 627474
Opened 14 years ago
Closed 14 years ago
The recent places merge broke non-libxul builds
Categories
(Toolkit :: Places, defect)
Tracking
()
RESOLVED
FIXED
mozilla2.0b10
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
Attachments
(2 files)
|
977 bytes,
patch
|
sdwilsh
:
review+
|
Details | Diff | Splinter Review |
|
2.42 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
I have a couple of patches to fix it.
|
Assignee | |
Comment 1•14 years ago
|
||
|
||
Updated•14 years ago
|
Component: General → Places
Product: Core → Toolkit
QA Contact: general → places
|
|
||
Comment 2•14 years ago
|
||
Comment on attachment 505487 [details] [diff] [review]
Part 1: link against libmozjs
r=sdwilsh
Attachment #505487 -
Flags: review?(sdwilsh) → review+
|
|
Assignee | |
Comment 3•14 years ago
|
||
Attachment #505493 -
Flags: review?(bzbarsky)
|
||
Comment 4•14 years ago
|
||
Comment on attachment 505493 [details] [diff] [review]
Part 2: Use nsIXPConnect::WrapNative directly in order to avoid having to link in libgklayout in non-libxul builds
r=me
Attachment #505493 -
Flags: review?(bzbarsky) → review+
|
|
Assignee | |
Comment 5•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/dc2f68e3ed26
http://hg.mozilla.org/mozilla-central/rev/f59a0940869f
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b10
You need to log in
before you can comment on or make changes to this bug.
Description
•