Closed Bug 627624 Opened 13 years ago Closed 13 years ago

Make the crashtest for bug 428844 actually test stuff

Categories

(Core :: DOM: Editor, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: bzbarsky, Assigned: ehsan.akhgari)

Details

Attachments

(1 file)

Right now it doesn't use reftest-wait, so ends the test before it reloads the subframe.
Attached patch Patch (v1)Splinter Review
This is kind of tricky, as the page loaded inside the iframe isn't valid, and results in an error page, which doesn't trigger the load event.  I think the test intended to unload the iframe page instead of really reloading it.  This patch does that.
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
Attachment #518905 - Flags: review?(roc)
Comment on attachment 518905 [details] [diff] [review]
Patch (v1)

You don't need to remove the event listener:
   iframe.removeEventListener("load", arguments.callee, false);
Attachment #518905 - Flags: review?(roc) → review+
http://hg.mozilla.org/mozilla-central/rev/770b9488e967
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: