627693 - GfxInfo.cpp fails to compile on mingw after landing bug 590373

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect)

Description

[Jacek Caban]

Attachment: fix v1.0

It's because of this part:

    PRUnichar *dllFileName = is64bitApp
                           ? L"igd10umd64.dll"
                           : L"igd10umd32.dll";

where we assign constant string to non-constant pointer. Fixing it also required making GetDLLVersion argument constant. I've also fixed a warning about NULL being used as an integer argument in GetFileVersionInfoW call.

Comment 1

[Benoit Jacob [:bjacob] (mostly away)]

Comment on attachment 505766 [details] [diff] [review]
fix v1.0

(In reply to comment #0)
> Created attachment 505766 [details] [diff] [review]
> fix v1.0
> 
> It's because of this part:
> 
>     PRUnichar *dllFileName = is64bitApp
>                            ? L"igd10umd64.dll"
>                            : L"igd10umd32.dll";
> 
> where we assign constant string to non-constant pointer. Fixing it also
> required making GetDLLVersion argument constant.

Indeed... that's why I didn't make that pointer constant myself. Thanks for not being as lazy as I am :-)

Comment 2

[Jacek Caban]

Thanks for review, pushed:

http://hg.mozilla.org/mozilla-central/rev/3cbf026c2ce2