Closed Bug 627693 Opened 12 years ago Closed 12 years ago

GfxInfo.cpp fails to compile on mingw after landing bug 590373

Categories

(Core :: Widget: Win32, defect)

Product:
Core
Component:
Widget: Win32
Platform:
x86
Windows 7
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: jacek, Assigned: jacek)

References

Details

Attachments

(1 file)

fix v1.0
2.58 KB, patch
bjacob
: review+
dbaron
: approval2.0+
Details | Diff | Splinter Review
Attached patch fix v1.0 — — Splinter Review 
It's because of this part:

    PRUnichar *dllFileName = is64bitApp
                           ? L"igd10umd64.dll"
                           : L"igd10umd32.dll";

where we assign constant string to non-constant pointer. Fixing it also required making GetDLLVersion argument constant. I've also fixed a warning about NULL being used as an integer argument in GetFileVersionInfoW call.
Attachment #505766 - Flags: review?(bjacob)
Comment on attachment 505766 [details] [diff] [review]
fix v1.0

(In reply to comment #0)
> Created attachment 505766 [details] [diff] [review]
> fix v1.0
> 
> It's because of this part:
> 
>     PRUnichar *dllFileName = is64bitApp
>                            ? L"igd10umd64.dll"
>                            : L"igd10umd32.dll";
> 
> where we assign constant string to non-constant pointer. Fixing it also
> required making GetDLLVersion argument constant.

Indeed... that's why I didn't make that pointer constant myself. Thanks for not being as lazy as I am :-)
Attachment #505766 - Flags: review?(bjacob) → review+
Attachment #505766 - Flags: approval2.0?
Attachment #505766 - Flags: approval2.0? → approval2.0+
Thanks for review, pushed:

http://hg.mozilla.org/mozilla-central/rev/3cbf026c2ce2
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Depends on: 629695
You need to log in before you can comment on or make changes to this bug.