627819 - Broken icon in the message "The Web Console logging API has been disabled by a script on this page"

Status: VERIFIED FIXED

(DevTools :: General, defect)

Description

[gadjo]

User-Agent:       Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b10pre) Gecko/20110121 Firefox/4.0b10pre
Build Identifier: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b10pre) Gecko/20110121 Firefox/4.0b10pre

After opening the console the icon for the first message is broken, see the attachment

Reproducible: Always

Comment 1

[gadjo]

Attachment: screenshot

Comment 2

[gadjo]

Invalid icon shows only for the message "The Web Console logging API (console.log, console.info, console.warn, console.error) has been disabled by a script on this". On the screenshot there's a polish version of this message.

Comment 3

[Rob Campbell [:rc] (:robcee)]

I haven't seen this myself yet. Not sure if this is an l10n issue or a bad file.

Marking this as dependent on our other icon bug which adds some better visual polish to the icons and color palette.

Comment 4

[Kevin Dangoor]

It's easy to reproduce this: just go to cnn.com (or any other site that defines the console object) and then open the web console and you'll see the message and the icon in question. I've cc'ed Patrick because it's possible that that icon is supposed to represent something.

Comment 5

[David Dahl :ddahl]

its showing this icon without the proper offsets: chrome://global/skin/icons/webconsole.png

Comment 6

[David Dahl :ddahl]

specifically, it is missing: -moz-image-region: rect(10px, 20px, 20px, 10px); (or whatever it's correct rect values are)

Comment 7

[Rob Campbell [:rc] (:robcee)]

so, this is the JS Error icon (the orange x).

Note that this is fixed in the blocking bug 609372. We should get that in.

Comment 8

[Patrick Walton (:pcwalton)]

Doh, I think I had caught all of those cases.

Comment 9

[Patrick Walton (:pcwalton)]

So this is caused by the half-baked CATEGORY_MISC. Killing it off and moving the "console API replaced" code to CATEGORY_JS should fix it.

Comment 10

[Patrick Walton (:pcwalton)]

Attachment: Proposed patch.

Quick fix attached.

Comment 11

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 506543 [details] [diff] [review]
Proposed patch.

I think gavin's traveling today. Moving to dolske for r+ing.

Comment 12

[Rob Campbell [:rc] (:robcee)]

incidentally, bug 609372 doesn't fix this afterall as I suggested in c#7. Just sayin'.

Comment 13

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 506543 [details] [diff] [review]
Proposed patch.

rs=me

Comment 14

[Daniel Holbert [:dholbert]]

Landed: http://hg.mozilla.org/mozilla-central/rev/2df909c5921d

Comment 15

[Maniac Vlad Florin (:vladmaniac)]

Verified fixed on 

Mozilla/5.0 (Windows NT 6.1; rv:2.0b12pre) Gecko/20110206 Firefox/4.0b12pre