Closed Bug 627858 Opened 9 years ago Closed 9 years ago

Use gfxContextAutoSaveRestore / gfxContextMatrixAutoSaveRestore in SVGDrawingCallback::operator()

Categories

(Core :: SVG, defect)

defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: dholbert, Assigned: dholbert)

Details

Attachments

(1 file)

While looking into bug 600207, I noticed that we should be using the gfx*AutoSaveRestore guard objects inside of SVGDrawingCallback::operator(), rather than manually saving & restoring.

Upcoming patch makes this change.  No anticipated functional impact -- just cleaner & more foolproof code.
Attached patch fixSplinter Review
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Attachment #505938 - Flags: review?(roc)
Attachment #505938 - Flags: review?(roc) → review+
Requesting landing approval - as noted in comment 0:
> No anticipated functional impact -- just
> cleaner & more foolproof code.

I ran this through TryServer as a sanity-check, and it passed all tests completed so far, modulo some known randomorange. (All tests have already completed on on Linux x86 opt & debug, as well as Linux64 opt)
Landed: http://hg.mozilla.org/mozilla-central/rev/612890499283
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.