Closed
Bug 627858
Opened 14 years ago
Closed 14 years ago
Use gfxContextAutoSaveRestore / gfxContextMatrixAutoSaveRestore in SVGDrawingCallback::operator()
Categories
(Core :: SVG, defect)
Core
SVG
Tracking
()
RESOLVED
FIXED
People
(Reporter: dholbert, Assigned: dholbert)
Details
Attachments
(1 file)
|
2.10 KB,
patch
|
jwatt
:
review+
roc
:
approval2.0+
|
Details | Diff | Splinter Review |
While looking into bug 600207, I noticed that we should be using the gfx*AutoSaveRestore guard objects inside of SVGDrawingCallback::operator(), rather than manually saving & restoring.
Upcoming patch makes this change. No anticipated functional impact -- just cleaner & more foolproof code.
|
Assignee | |
Comment 1•14 years ago
|
||
|
||
Updated•14 years ago
|
Attachment #505938 -
Flags: review?(roc) → review+
|
|
Assignee | |
Updated•14 years ago
|
Attachment #505938 -
Flags: approval2.0?
|
|
Assignee | |
Comment 2•14 years ago
|
||
Requesting landing approval - as noted in comment 0:
> No anticipated functional impact -- just
> cleaner & more foolproof code.
I ran this through TryServer as a sanity-check, and it passed all tests completed so far, modulo some known randomorange. (All tests have already completed on on Linux x86 opt & debug, as well as Linux64 opt)
Attachment #505938 -
Flags: approval2.0? → approval2.0+
|
|
Assignee | |
Comment 3•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•