tab-modal prompts should handle Cmd-. on OS X

RESOLVED FIXED in mozilla2.0b12

Status

()

defect
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: Dolske, Assigned: Dolske)

Tracking

unspecified
mozilla2.0b12
x86
macOS
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Posted patch Patch v.1Splinter Review
When I implemented tabprompts.xml, I left out the Cmd-. handler (as dialog.xml had), because it seemed to do nothing and I couldn't find any online references that suggested it was a standard shortcut.

Bug 613710 reveals that this is, in fact, a long-standing standard action on OS X. And it was also broken on trunk. :)

Patch here makes Cmd-. work for tab-modal prompts. Note that dialog.xml used |phase="capturing"| instead of |group="system"|, I'm not sure why it would treat this one differently.

[Untested at the moment, waiting for a build.]
Attachment #505980 - Flags: review?(gavin.sharp)
Attachment #505980 - Flags: review?(gavin.sharp)
Attachment #505980 - Flags: review+
Attachment #505980 - Flags: approval2.0+
Tested on my build with 613710 applied, and Cmd-. works properly in both window-modal and tab-modal prompts.
Assignee: nobody → dolske
http://hg.mozilla.org/mozilla-central/rev/b0dc575e0a12
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b12
You need to log in before you can comment on or make changes to this bug.