Closed
Bug 627896
Opened 14 years ago
Closed 14 years ago
tab-modal prompts should handle Cmd-. on OS X
Categories
(Toolkit :: General, defect)
Tracking
()
RESOLVED
FIXED
mozilla2.0b12
People
(Reporter: Dolske, Assigned: Dolske)
References
Details
Attachments
(1 file)
|
1.22 KB,
patch
|
Gavin
:
review+
Gavin
:
approval2.0+
|
Details | Diff | Splinter Review |
When I implemented tabprompts.xml, I left out the Cmd-. handler (as dialog.xml had), because it seemed to do nothing and I couldn't find any online references that suggested it was a standard shortcut.
Bug 613710 reveals that this is, in fact, a long-standing standard action on OS X. And it was also broken on trunk. :)
Patch here makes Cmd-. work for tab-modal prompts. Note that dialog.xml used |phase="capturing"| instead of |group="system"|, I'm not sure why it would treat this one differently.
[Untested at the moment, waiting for a build.]
Attachment #505980 -
Flags: review?(gavin.sharp)
|
||
Updated•14 years ago
|
Attachment #505980 -
Flags: review?(gavin.sharp)
Attachment #505980 -
Flags: review+
Attachment #505980 -
Flags: approval2.0+
|
Assignee | |
Comment 1•14 years ago
|
||
Tested on my build with 613710 applied, and Cmd-. works properly in both window-modal and tab-modal prompts.
|
|
||
Updated•14 years ago
|
Assignee: nobody → dolske
|
||
Comment 2•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b12
You need to log in
before you can comment on or make changes to this bug.
Description
•