628031 - Constant Pool parser gives a namespace with a name index of 0 the "Undefined" atom.

Status: RESOLVED WONTFIX

(Tamarin Graveyard :: Documentation, defect, P4)

Description

[Jasper St. Pierre]

User-Agent:       Mozilla/5.0 (X11; Linux x86_64; rv:2.0b10pre) Gecko/20110120 Firefox-4.0/4.0b10pre
Build Identifier: 

AbcParser.cpp, in parseCpool:

if (index)
{
  // ...
}
else
{
    // issue this looks wrong.  should uri be ""?
    Atom uri = undefinedAtom;
    cpool_ns.set(i, core->internNamespace(core->newNamespace(uri, type)));
}

It indeed does look wrong, according to public documentation: http://learn.adobe.com/wiki/display/AVM2/4.4+String

It's also a simple patch, and that patch is attached.

Reproducible: Always

Comment 1

[Jasper St. Pierre]

Attachment: Patch.

Comment 2

[Steven Johnson]

Hmm... it may be "wrong", but we'll need to vet it against existing content to see if this change would break something. (It may be that it's simpler to change the documentation to match the code.)

Comment 3

[Edwin Smith]

right, the "bug" is that the docs and verifier don't agree.  we can consider a doc patch as well, both would resolve the discrepancy.  If we change the verifier then we can decide to do it retroactively or only for new versions.

Comment 4

[Steven Johnson]

Yeah, IMHO changing the docs is the simpler and safer fix... granted the current behavior is arguably useless, it's easy to workaround.

Comment 5

[Jasper St. Pierre]

Should I resolve this as NOTABUG, or do we want to resolve this as a doc bug?

The only case that I can think of that would break this is if somebody is using 'pushnamespace 0' as a synonym for 'pushundefined', otherwise a Multiname with an undefined namespace won't ever resolve.

Comment 6

[Lars T Hansen]

You should leave it alone; once you filed it, we deal with it.  (Though not always in a timely manner.)

Comment 7

[Steven Johnson]

FWIW, I vote we address this by documenting the peculiarity.

Comment 8

[Dan Smith]

Assigning to Andre to for the doc fix.

Comment 9

[Sylvestre Ledru [:Sylvestre]]

Tamarin is a dead project now. Mass WONTFIX.

Comment 10

[Sylvestre Ledru [:Sylvestre]]

Tamarin isn't maintained anymore. WONTFIX remaining bugs.