628063 - IndexedDB: Indexes created after data are added are sometimes improperly populated

Status: RESOLVED FIXED

Description

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Created attachment 506159 [details] [diff] [review]
Patch, v1

Oops. This is bad, we don't handle index creation after data are added in two cases:

1. The index name != the indexed property name (forehead slap, idiocy).
2. The indexed property is an integer rather than a string.

Both are bad, and now fixed. Our tests magically missed *both* of these cases :(

Comment 1

[Ben Turner (not reading bugmail, use the needinfo flag!)]

This does not need beta coverage, blocking final is all it needs.

Comment 2

[Ben Turner (not reading bugmail, use the needinfo flag!)]

http://hg.mozilla.org/mozilla-central/rev/c30066b12743