IndexedDB: Indexes created after data are added are sometimes improperly populated

RESOLVED FIXED

Status

()

Core
DOM: IndexedDB
RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: Ben Turner (not reading bugmail, use the needinfo flag!), Assigned: Ben Turner (not reading bugmail, use the needinfo flag!))

Tracking

unspecified
Points:
---

Firefox Tracking Flags

(blocking2.0 final+)

Details

(Whiteboard: [softblocker])

Attachments

(1 attachment)

Created attachment 506159 [details] [diff] [review]
Patch, v1

Oops. This is bad, we don't handle index creation after data are added in two cases:

1. The index name != the indexed property name (forehead slap, idiocy).
2. The indexed property is an integer rather than a string.

Both are bad, and now fixed. Our tests magically missed *both* of these cases :(
Attachment #506159 - Flags: review?(jonas)
This does not need beta coverage, blocking final is all it needs.
Attachment #506159 - Flags: review?(jonas) → review+
blocking2.0: ? → final+
Whiteboard: [softblocker]
http://hg.mozilla.org/mozilla-central/rev/c30066b12743
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Component: DOM → DOM: IndexedDB
Version: Trunk → unspecified
You need to log in before you can comment on or make changes to this bug.