628074 - at startup – exception raised : Collection <NSCFArray: 0x1c83160> was mutated while being enumerated

Status: VERIFIED FIXED

(Camino Graveyard :: Location Bar & Autocomplete, defect)

Description

[philippe (part-time)]

Attachment: console logging

1. Start up browser
2. No window came up
3. Cmd-N or Cmd-L did not open a window

No history in the menu, only a subset of bookmarks loaded

4. Quit, restart ( about 30 seconds between the two)
5. The 'Restore pages ?' dialog comes up

Everything is back to normal

There was 1 tab left open in the previous session

I had previously experienced that with one of the WIP patches for bug 506345, see bug 506345 comment 109 and 110.

(there is nothing else in Console that might help :-()

Comment 1

[Stuart Morgan]

I bet the autocomplete system can start reading the bookmarks before they are done loading; re-reading the threading of the bookmark manager it looks like it's pretty much on the honor system :P

I'll make the autocomplete system do the right thing (and maybe make it harder to do the wrong thing in the manager itself).

Comment 2

[Chris Peterson [:cpeterson]]

I think I saw this exception (or a similar one) recently: 

1. Exit Camino with two tabs open: the History view and some other web page.
2. Restart Camino (with "Load the pages that were open before quitting").
3. As the History view is initializing, the second web page is loaded and tries to add itself to Today's history.

This causes the enumerator exception.

Comment 3

[Stuart Morgan]

Hm, that would be a different one since the log here is all bookmark classes. Sounds like we have two problems :(

Comment 4

[philippe (part-time)]

This may be related, eventually:

bookmark/history ranking lost after a quick restart

str:
1. quit Camino
2. restart quickly (within 30seconds maybe)
3. type something in the location bar that has a high ranking

AR: the autocomplete window appears with totally different results from expected
ER: the autocomplete window shows the high ranking bookmark and/or history items as first choice(s).

By example: I have http://www.guardian.co.uk/ in my bookmarks and history. It has a very high ranking as it is visited daily. After the str above, typing 'gu' should show guardian.co.uk in the BM's, and recently read/visited articles in the history. None did show up. Instead only one bookmark came up (happens to contain the word 'guard' in the page title) and totally unrelated history items. Typing more characters after 'gu' didn't help.

Restarting the browser usually resolves the issue. It doesn't always happen, but I've seen it quite a few times now. The short interval between quit and restart seems key.

Nothing is logged in console.

Comment 5

[philippe (part-time)]

(In reply to comment #4)
> This may be related, eventually:

BTW, this behaviour persists during the whole session. Iow, it is not something that (only) happens shortly after startup.

Comment 6

[Stuart Morgan]

Attachment: fix

This prevents a race between autocomplete and bookmark loading. I can reproduce it in simple testing, so it was definitely happening, but I don't get the exception; that would be a lot more timing-sensitive. It absolutely *could* produce the exception though, so I'm pretty confident that this is the fix. It certainly makes the code more correct :)

Comment 7

[Stuart Morgan]

Landed http://hg.mozilla.org/camino/rev/b47899cc1844

Chris, I can't reproduce your bug offhand. Can you file that if you haven't already?

Comment 8

[philippe (part-time)]

I haven't been able to reproduce any of these issues since this landed (or accidentally suffer from it…).
Marking as verified.