Closed
Bug 628202
Opened 13 years ago
Closed 13 years ago
SeaMonkey Release Run fails, missing slavebuilddir in builder properties
Categories
(SeaMonkey :: Release Engineering, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: Callek, Assigned: Callek)
References
Details
Attachments
(1 file, 1 obsolete file)
6.16 KB,
patch
|
kairo
:
review+
|
Details | Diff | Splinter Review |
During my "GO" on the SM buildbot for 2.0.12 (our first GO on buildbot 0.8) I encountered: ----- Traceback (most recent call last): File "/tools/buildbot-0.8.0/lib/python2.6/site-packages/buildbot-0.8.2_hg_161d0a80925c_default-py2.6.egg/buildbot/process/buildstep.py", line 728, in startStep d.addCallback(self._startStep_2) File "/tools/buildbot-0.8.0/lib/python2.6/site-packages/Twisted-9.0.0-py2.6-linux-i686.egg/twisted/internet/defer.py", line 190, in addCallback callbackKeywords=kw) File "/tools/buildbot-0.8.0/lib/python2.6/site-packages/Twisted-9.0.0-py2.6-linux-i686.egg/twisted/internet/defer.py", line 181, in addCallbacks self._runCallbacks() File "/tools/buildbot-0.8.0/lib/python2.6/site-packages/Twisted-9.0.0-py2.6-linux-i686.egg/twisted/internet/defer.py", line 323, in _runCallbacks self.result = callback(self.result, *args, **kw) --- <exception caught here> --- File "/tools/buildbot-0.8.0/lib/python2.6/site-packages/buildbot-0.8.2_hg_161d0a80925c_default-py2.6.egg/buildbot/process/buildstep.py", line 769, in _startStep_2 skip = self.start() File "/tools/buildbot-0.8.0/lib/python2.6/site-packages/buildbot-0.8.2_hg_161d0a80925c_default-py2.6.egg/buildbot/steps/shell.py", line 212, in start command = properties.render(self.command) File "/tools/buildbot-0.8.0/lib/python2.6/site-packages/buildbot-0.8.2_hg_161d0a80925c_default-py2.6.egg/buildbot/process/properties.py", line 108, in render return [ self.render(e) for e in value ] File "/tools/buildbot-0.8.0/lib/python2.6/site-packages/buildbot-0.8.2_hg_161d0a80925c_default-py2.6.egg/buildbot/process/properties.py", line 106, in render return value.render(self.pmap) File "/tools/buildbot-0.8.0/lib/python2.6/site-packages/buildbot-0.8.2_hg_161d0a80925c_default-py2.6.egg/buildbot/process/properties.py", line 194, in render s = self.fmtstring % pmap File "/tools/buildbot-0.8.0/lib/python2.6/site-packages/buildbot-0.8.2_hg_161d0a80925c_default-py2.6.egg/buildbot/process/properties.py", line 169, in __getitem__ rv = properties[key] File "/tools/buildbot-0.8.0/lib/python2.6/site-packages/buildbot-0.8.2_hg_161d0a80925c_default-py2.6.egg/buildbot/process/properties.py", line 50, in __getitem__ rv = self.properties[name][0] exceptions.KeyError: 'slavebuilddir' -------- This is due to changes in clobberrer. Filing a bug as tracking, and so I can get an official r+ on my changes, since I'm relatively new to this. I will check in and "GO" before review though.
Assignee | ||
Comment 1•13 years ago
|
||
Attachment #506311 -
Flags: review?(kairo)
Assignee | ||
Comment 2•13 years ago
|
||
_actually_ fix sm, last patch was calendar/ somehow... (I'm not even sure how I had it open) I'm backing out the calendar checkin from buildbot configs now...
Attachment #506311 -
Attachment is obsolete: true
Attachment #506312 -
Flags: review?(kairo)
Attachment #506311 -
Flags: review?(kairo)
Assignee | ||
Comment 3•13 years ago
|
||
Comment on attachment 506312 [details] [diff] [review] fix sm release configs >+def builderPrefix(s, platform=None): >+ if platform: >+ return "release-%s-%s_%s" % (releaseConfig['sourceRepoName'], platform, s) >+ else: >+ return "release-%s-%s" % (releaseConfig['sourceRepoName'], s) >+ Please review this hunk with: http://hg.mozilla.org/build/buildbot-configs/rev/18aca1cafb9f
Comment 4•13 years ago
|
||
Comment on attachment 506312 [details] [diff] [review] fix sm release configs Looks good to me given it seems to work :) Thanks for digging into that! (BTW, it looks like we're not using the platform pram on builderPrefix() right now, but I guess that's there for compat once we switch over to "real" 0.8 release stuff.
Attachment #506312 -
Flags: review?(kairo) → review+
Assignee | ||
Comment 5•13 years ago
|
||
(In reply to comment #4) > Comment on attachment 506312 [details] [diff] [review] > fix sm release configs > > (BTW, it looks like we're not using the platform pram on builderPrefix() right > now, but I guess that's there for compat once we switch over to "real" 0.8 > release stuff. Yea, copied straight from the Firefox config. I also noticed after I actually fixed this, that we *can* use the param and avoid an extra python string manipulation too, which I might just do without review later.
Assignee | ||
Updated•13 years ago
|
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•