628222 - Add support for >= libnotify-0.7.0

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Priit Laes]

User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; et-ee) AppleWebKit/534.16+ (KHTML, like Gecko) Version/5.0 Safari/534.16+ Epiphany/2.91.5
Build Identifier: 

Libnotify-0.7.0 has had an API change, so a patch is required to support that.

Reproducible: Always

Comment 1

[Priit Laes]

Attachment: xulrunner-libnotify-0.7.patch

Comment 2

[Reed Loden [:reed]]

Comment on attachment 506331 [details] [diff] [review]
xulrunner-libnotify-0.7.patch

Seems a bit overkill for just an added NULL. Why not:

  mNotification = notify_notification_new(mAlertTitle.get(),
                                          mAlertText.get(),
                                          NULL
#if NOTIFY_CHECK_VERSION(0,7,0)
                                          , NULL
#endif
                                          );

Comment 3

[Jory A. Pratt [:anarchy]]

(In reply to comment #2)
> Comment on attachment 506331 [details] [diff] [review]
> xulrunner-libnotify-0.7.patch
> 
> Seems a bit overkill for just an added NULL. Why not:
> 
>   mNotification = notify_notification_new(mAlertTitle.get(),
>                                           mAlertText.get(),
>                                           NULL
> #if NOTIFY_CHECK_VERSION(0,7,0)
>                                           , NULL
> #endif
>                                           );

Reed, your not adding a NULL your removing a NULL, either way the patch is extreme overkill.

Comment 4

[Priit Laes]

Attachment: xulrunner-libnotify-0.7.0-v2.patch

Updated patch with less overkill...

Comment 5

[Karl Tomlinson (:karlt)]

The ABI change was here:
http://git.gnome.org/browse/libnotify/commit/?id=27e05d0f9562a26163493d6cc1d5924b9a4ebf68
with soname change, also before 0.7.0, here:
http://git.gnome.org/browse/libnotify/commit/?id=5b1a862c59a8d9c5ffecd0add2e62a0b1adb01ad
so distros using the new library can and will have to continue to provide the old library for backward compatibility.

I see no change to pkgconfig name, so we can't easily build against the old library.

Is there a more stable package providing a similar service that we can use?

Comment 6

[Karl Tomlinson (:karlt)]

Comment on attachment 506514 [details] [diff] [review]
xulrunner-libnotify-0.7.0-v2.patch

I don't see any need for the ABI change.
The old functions could have been kept as no-ops.

But this is what we'll need to do if we want to support building against 0.7.0+.

Please change the C-style /* */ comments to C++ // comments to match the file style.

Comment 7

[Priit Laes]

Attachment: xulrunner-libnotify-0.7-v3.patch

Comment 8

[Mounir Lamouri (:mounir)]

Pushed:
http://hg.mozilla.org/mozilla-central/rev/ca548ef9d8c6

Comment 9

[Jory A. Pratt [:anarchy]]

If we can I would like to see this landed after .15 is released.

Comment 10

[Jory A. Pratt [:anarchy]]

Attachment: plaes's patch for mozilla-1.9.2

Is same patch just updated to apply to mozilla-1.9.2

Comment 11

[Daniel Veditz [:dveditz]]

Comment on attachment 517916 [details] [diff] [review]
plaes's patch for mozilla-1.9.2

Approved for 1.9.2.16, a=dveditz for release-drivers

Code-freeze for non-blocking changes is Thursday Mar 17; after that approval will be rescinded for this release

Comment 12

[Mounir Lamouri (:mounir)]

Pushed in 1.9.2 branch:
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/19270105d4f6