Closed
Bug 628314
Opened 13 years ago
Closed 13 years ago
Solution for encapsulating privates
Categories
(Add-on SDK Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: irakli, Assigned: irakli)
References
Details
Attachments
(2 files)
Current implementation of Traits also takes care of private property hiding, as traits are going to be simplified peace of functionality responsible for private hiding will have to be provided in alternative fusion.
|
Assignee | |
Updated•13 years ago
|
Assignee: nobody → rFobic
|
|
Assignee | |
Comment 1•13 years ago
|
||
|
|
Assignee | |
Updated•13 years ago
|
Attachment #506471 -
Flags: review?(myk)
|
|
Assignee | |
Updated•13 years ago
|
Attachment #506471 -
Attachment mime type: text/html → text/plain
|
|
Assignee | |
Comment 2•13 years ago
|
||
Review link seems to be broken so posting it here: https://github.com/mozilla/addon-sdk/pull/101/
|
||
Comment 3•13 years ago
|
||
Comment on attachment 506471 [details]
Pointer to pull request
Very cool. A few issues. Comments in the pull request!
Attachment #506471 -
Flags: review?(myk) → review-
|
|
Assignee | |
Comment 4•13 years ago
|
||
|
|
Assignee | |
Comment 5•13 years ago
|
||
Comment on attachment 512115 [details]
Pointer to pull request
Version 2, addressing review comments.
Attachment #512115 -
Flags: review?(myk)
|
|
||
Comment 6•13 years ago
|
||
Comment on attachment 512115 [details] Pointer to pull request It looks like test.js and test/assert.js accidentally got into this pull request. r=myk on the other files, while those two files should be checked in as the fix for bug 632572.
Attachment #512115 -
Flags: review?(myk) → review+
|
|
Assignee | |
Updated•13 years ago
|
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•