Closed Bug 62832 Opened 24 years ago Closed 24 years ago

Make an option for "newemailtech" to be default

Categories

(Bugzilla :: Bugzilla-General, defect, P3)

Tracking

()

RESOLVED FIXED
Bugzilla 2.12

People

(Reporter: jacob, Assigned: dmosedale)

References

Details

(Whiteboard: 2.12)

Attachments

(3 files)

I wrote a patch that will allow newemailtech to be set as the default mailing
scheme via editparams.cgi.  This patch does not change any existing users
preference, it only makes it so all new users have newemailtech turned on by
default (they still have the option to turn it off).  Also, the default value
for this is "off" so nothing happens unless you specifcally change the setting
in editparams.cgi.
As mentioned above, this patch does not change any users default settings.  If
you wish to change all your users prefs to the newemailtech setting, you must
issue the following SQL command inside the "bugs" database:

update profiles set newemailtech = '1';
Keywords: patch, review
Whiteboard: 2.12
See comment in bug #63272
Assignee: tara → dmose
Depends on: 63272
*** Bug 63272 has been marked as a duplicate of this bug. ***
No longer depends on: 63272
Blocks: 17464
Attached patch patch v2Splinter Review
Ok, I've revised the patch in the following ways:

	* use Param() instead of $::param(), so that defparams.pl gets read as
	  necessary

	* ignore newemailtechdefault if newemailtech is turned off

	* default both newemailtech and newemailtechdefault on in defparams.pl

	* change verbiage in defparams.pl to reflect new defaults

	* give Jake credit in the boilerplate contributor list.

All makes sence to me...

Thanks for the boiler plate credit, BTW... I always forget to do that.  We may
also want to change the verbage in userprefs.cgi?bank=diffs to reflect to the
users that this is no longer bleeding edge and is recommended, blah, blah...
Attached patch patch v3Splinter Review
Status: NEW → ASSIGNED
Jake: excellent point.  I've uploaded a new patch with that change made.

I've also added several folks to the CC list.  If one of you guys could give me
an r=, I'll check this in.
Patch checked in; r=endico & cyeh.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Sorry for the spam, but I needed to be able to query for all of these correctly.
Target Milestone: --- → Bugzilla 2.12
Moving closed bugs to Bugzilla product
Component: Bugzilla → Bugzilla-General
Product: Webtools → Bugzilla
Version: other → unspecified
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: