628353 - DATA_CLONE_ERR should be exposed on DOMException

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1

So it turns out DOMException.DATA_CLONE_ERR isn't defined...

Comment 1

[Mounir Lamouri (:mounir)]

Comment on attachment 506484 [details] [diff] [review]
Patch v1

>diff --git a/dom/interfaces/core/nsIDOMDOMException.idl b/dom/interfaces/core/nsIDOMDOMException.idl
>--- a/dom/interfaces/core/nsIDOMDOMException.idl
>+++ b/dom/interfaces/core/nsIDOMDOMException.idl
>@@ -73,12 +73,13 @@ interface nsIDOMDOMException : nsISuppor
>   // Introduced in DOM Level 2:
>   const unsigned short      NAMESPACE_ERR                  = 14;
>   // Introduced in DOM Level 2:
>   const unsigned short      INVALID_ACCESS_ERR             = 15;
>   // Introduced in DOM Level 3:
>   const unsigned short      VALIDATION_ERR                 = 16;
>   // Introduced in DOM Level 3:
>   const unsigned short      TYPE_MISMATCH_ERR              = 17;
>+  const unsigned short      DATA_CLONE_ERR                 = 25;
> 
>   readonly attribute unsigned long   code;
> };

Shouldn't you update the UUID?

Comment 2

[Johnny Stenback (:jst)]

Comment on attachment 506484 [details] [diff] [review]
Patch v1

I don't think we need to change the UUID here, this is a binary compatible change, but users of this will need to recompile if they actually use this removed constant. Either way, this is material for post 2.0...

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch for checkin

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

The future is now.

Comment 5

[Boris Zbarsky [:bzbarsky]]

http://hg.mozilla.org/projects/cedar/rev/a66d47226d90

Comment 6

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/a66d47226d90