DATA_CLONE_ERR should be exposed on DOMException

RESOLVED FIXED in mozilla5

Status

()

defect
RESOLVED FIXED
9 years ago
8 years ago

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Tracking

Trunk
mozilla5
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Posted patch Patch v1 (obsolete) — Splinter Review
So it turns out DOMException.DATA_CLONE_ERR isn't defined...
Attachment #506484 - Flags: review?(jst)
Comment on attachment 506484 [details] [diff] [review]
Patch v1

>diff --git a/dom/interfaces/core/nsIDOMDOMException.idl b/dom/interfaces/core/nsIDOMDOMException.idl
>--- a/dom/interfaces/core/nsIDOMDOMException.idl
>+++ b/dom/interfaces/core/nsIDOMDOMException.idl
>@@ -73,12 +73,13 @@ interface nsIDOMDOMException : nsISuppor
>   // Introduced in DOM Level 2:
>   const unsigned short      NAMESPACE_ERR                  = 14;
>   // Introduced in DOM Level 2:
>   const unsigned short      INVALID_ACCESS_ERR             = 15;
>   // Introduced in DOM Level 3:
>   const unsigned short      VALIDATION_ERR                 = 16;
>   // Introduced in DOM Level 3:
>   const unsigned short      TYPE_MISMATCH_ERR              = 17;
>+  const unsigned short      DATA_CLONE_ERR                 = 25;
> 
>   readonly attribute unsigned long   code;
> };

Shouldn't you update the UUID?
Comment on attachment 506484 [details] [diff] [review]
Patch v1

I don't think we need to change the UUID here, this is a binary compatible change, but users of this will need to recompile if they actually use this removed constant. Either way, this is material for post 2.0...
Attachment #506484 - Flags: review?(jst) → review+
Assignee

Updated

8 years ago
Depends on: post2.0
Whiteboard: [needs review] → [needs landing]
Whiteboard: [needs landing] → [needs landing][post-2.0]
Target Milestone: mozilla2.0 → Future
Assignee

Comment 3

8 years ago
Attachment #506484 - Attachment is obsolete: true
Assignee

Comment 4

8 years ago
The future is now.
Keywords: checkin-needed
Whiteboard: [needs landing][post-2.0]
http://hg.mozilla.org/projects/cedar/rev/a66d47226d90
Flags: in-testsuite+
Whiteboard: fixed-in-cedar
Target Milestone: Future → mozilla2.2

Comment 6

8 years ago
http://hg.mozilla.org/mozilla-central/rev/a66d47226d90
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: fixed-in-cedar
You need to log in before you can comment on or make changes to this bug.