628377 - Bypass graphics blacklist on Talos

Status: RESOLVED INVALID

(Testing :: Talos, defect)

Description

[Benoit Jacob [:bjacob] (mostly away)]

Attachment: force-enable gfx features

Note: this blocks the hardblocker bug 623338.

We need to blacklist old drivers, but test slaves still have old drivers. This patch sets preferences to bypass the blacklist so that Talos tests are unaffected.

Comment 1

[Benoit Jacob [:bjacob] (mostly away)]

Notice that the preference gfx.direct2d.force-enable only exists on Windows. On non-windows platforms, there is not even a direct2d branch. Is that OK?

Also, the webgl.force-enable pref is going to be introduced by a new patch, it doesn't exist at the moment.

Comment 2

[Benoit Jacob [:bjacob] (mostly away)]

Attachment: force-enable gfx features

oops, previous patch had lots of unwanted indentation changes by visual studio. sorry.

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 506518 [details] [diff] [review]
force-enable gfx features

can we add a comment to explain why we are adding these new preferences.  Also, this needs to run through talos staging.  I am not sure if this was done or you need somebody (that could be me) to do it.

Comment 4

[Benoit Jacob [:bjacob] (mostly away)]

Attachment: force-enable gfx features, updated

Here's a patch with such a comment; carried forward r+.

Is there anything more that I can/should do to help landing this?

Comment 5

[Benoit Jacob [:bjacob] (mostly away)]

(In reply to comment #3)
> Also, this needs to run through talos staging.  I am not sure if this
> was done or you need somebody (that could be me) to do it.

I didn't do anything else than writing this patch and pinging you. How can I help 'running this through talos staging' ?

Comment 6

[Benoit Jacob [:bjacob] (mostly away)]

Since drivers were upgraded today on test slaves, this is no longer needed.

Thanks for your help and sorry for the noise! I couldn't know how long it would take to update the drivers on test slaves.

I guess that INVALID is the most appropriate bug resolution...