Closed Bug 628382 Opened 9 years ago Closed 9 years ago

Use 24 bit depth buffers where available

Categories

(Core :: Canvas: WebGL, defect)

x86
Windows 7
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla2.0b11

People

(Reporter: bjacob, Assigned: bjacob)

Details

Attachments

(1 file, 2 obsolete files)

Attached patch use 24bit depth (obsolete) — Splinter Review
On desktop opengl, and on ES where OES_depth24 is supported, we should use 24 bit depth buffers.

It's not just a tiny aesthetic detail, the #audio team has reported various problems (slowness) with 16 bit depth buffers, on both windows and mac, i think with Intel cards (on windows, that was using ANGLE).
Attachment #506510 - Flags: review?(vladimir)
So this is good, but is not enough -- ANGLE doesn't export OES_depth24, it exports OES_packed_depth_stencil.  So if packed_depth_stencil is supported and OES_depth24 is not, then we need to basically create depth renderbuffers as DEPTH24_STENCIL8 always.
Attached patch use 24bit depth, updated (obsolete) — Splinter Review
Thanks for catching this!
Attachment #506510 - Attachment is obsolete: true
Attachment #506844 - Flags: review?(vladimir)
Attachment #506510 - Flags: review?(vladimir)
argh, typo
this time it's good
Attachment #506844 - Attachment is obsolete: true
Attachment #506846 - Flags: review?(vladimir)
Attachment #506844 - Flags: review?(vladimir)
Comment on attachment 506846 [details] [diff] [review]
use 24bit depth, updated

looks good to me :)
Attachment #506846 - Flags: review?(vladimir) → review+
Attachment #506846 - Flags: approval2.0+
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Assignee: nobody → bjacob
Target Milestone: --- → mozilla2.0b11
You need to log in before you can comment on or make changes to this bug.