628382 - Use 24 bit depth buffers where available

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Benoit Jacob [:bjacob] (mostly away)]

Attachment: use 24bit depth

On desktop opengl, and on ES where OES_depth24 is supported, we should use 24 bit depth buffers.

It's not just a tiny aesthetic detail, the #audio team has reported various problems (slowness) with 16 bit depth buffers, on both windows and mac, i think with Intel cards (on windows, that was using ANGLE).

Comment 1

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

So this is good, but is not enough -- ANGLE doesn't export OES_depth24, it exports OES_packed_depth_stencil.  So if packed_depth_stencil is supported and OES_depth24 is not, then we need to basically create depth renderbuffers as DEPTH24_STENCIL8 always.

Comment 2

[Benoit Jacob [:bjacob] (mostly away)]

Attachment: use 24bit depth, updated

Thanks for catching this!

Comment 3

[Benoit Jacob [:bjacob] (mostly away)]

argh, typo

Comment 4

[Benoit Jacob [:bjacob] (mostly away)]

Attachment: use 24bit depth, updated

this time it's good

Comment 5

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 506846 [details] [diff] [review]
use 24bit depth, updated

looks good to me :)

Comment 6

[Benoit Jacob [:bjacob] (mostly away)]

http://hg.mozilla.org/mozilla-central/rev/b2ee69bb52c3