Closed Bug 628477 Opened 9 years ago Closed 9 years ago

nsCSSRendering.cpp:360: warning: ‘void PaintBackgroundLayer(...) declared ‘static’ but never defined

Categories

(Core :: Layout, defect)

defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: dholbert, Assigned: dholbert)

References

Details

(Whiteboard: [build_warning])

Attachments

(1 file)

Filing bug on this build warning:

> layout/base/nsCSSRendering.cpp:360: warning: ‘void PaintBackgroundLayer(nsPresContext*, nsIRenderingContext&, nsIFrame*, PRUint32, const nsRect&, const nsRect&, const nsRect&, const nsStyleBackground&, const nsStyleBackground::Layer&)’ declared ‘static’ but never defined

Looks like this function is indeed declared but never defined or called:

http://mxr.mozilla.org/mozilla-central/search?string=PaintBackgroundLayer&find=nsCSSRendering.cpp&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central

Its definition & caller were deleted in this cset:
  http://hg.mozilla.org/mozilla-central/rev/475fe8dd48a3
but the declaration remained.

I think the declaration wants to go away.
Attached patch fixSplinter Review
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Attachment #506604 - Flags: review?(roc)
Attachment #506604 - Flags: approval2.0?
Attachment #506604 - Flags: review?(roc)
Attachment #506604 - Flags: review+
Attachment #506604 - Flags: approval2.0?
Attachment #506604 - Flags: approval2.0+
Landed: http://hg.mozilla.org/mozilla-central/rev/6a097e294828
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.