62856 - PSM trunk build for OS/2

Status: VERIFIED FIXED

(Core :: Security: PSM, defect, P3)

Description

[jhp (no longer active)]

This bug is for file changes necessary to get PSM building in the 
trunk under OS/2.  This bug depends on bug 60912.

Comment 1

[jhp (no longer active)]

Attachment: OS/2 patch for files in security/psm

Comment 2

[timeless]

+        if (control != NULL) {
iirc we don't like explicit comparisons with NULL.

If brendan agrees then an overlay patch (to the entire file) should be
considered. If [e-mail] (Javier Pedemonte) does not want that bug
assigned to him, then he should assign it to me ([e-mail] mark P2
mozilla0.9 blocked by this bug)

Comment 3

[jhp (no longer active)]

Attachment: latest patch

Comment 4

[Dmitry Kubov]

Its not good for EMX build. XP_OS2 should be used.

+#ifdef XP_OS2_VACPP

+#define INCL_DOSSESMGR

+#define INCL_DOSERRORS

+#define INCL_DOSPROCESS

+#include "os2.h"

+#endif

Comment 5

[jhp (no longer active)]

Attachment: updated cmtcmn.h for EMX

Comment 6

[Mike Kaply [:mkaply]]

salsero suggested I reassign this bug to you.

We are just trying to get OS/2 changes in so we can build PSM on the tip.

I'm willing to check them in if that is possible

Comment 7

[jhp (no longer active)]

Attachment: updated security/psm/Makefile.in - supercedes above patches

Comment 8

[Javier Delgadillo]

This patch touces both mozilla/security/psm/server/Makefile and
mozilla/security/psm/server/Makefile.in.  It should only have to touch one of
the two.  Do you build using autoconf? Or the nmake /f makefile.win convention?

Comment 9

[Javier Delgadillo]

Could you try one thing the mozilla/security/psm/server/Makefile,

Try

MKPROG = CCC in there to see if we can get rid of the dependency of the
CPLUSPLUS runtime at link.

Comment 10

[Javier Delgadillo]

I've got this patch staged.  Hopefully the tree will open earlier than 5 pm
tomorrow so I can check it in andnot have to sit around late into the evening
making sure the builds didn't break.

Comment 11

[Javier Delgadillo]

Patch checked in.  

Comment 12

[Dmitry Kubov]

Attachment: updated security/psm/server/Makefile for EMX

Comment 13

[jhp (no longer active)]

The patch for security/psm/server/Makefile was not checked in 
correctly.  I am attaching a patch that fixes this, as well as adding 
the EMX changes from patch 02/07/01.  See below.

Comment 14

[jhp (no longer active)]

Attachment: fix for psm/server/Makefile

Comment 15

[Javier Delgadillo]

Final patch to Makefile checked in.

Comment 16

[jhp (no longer active)]

*** Bug 62016 has been marked as a duplicate of this bug. ***

Comment 17

[John Unruh]

Verified per javi's comments.