Closed Bug 628576 Opened 13 years ago Closed 12 years ago

Need a better way to handle window.close()

Categories

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Product:
Mozilla QA Graveyard
Component:
Mozmill Tests
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: u279076, Assigned: whimboo)

References

Details

(Whiteboard: [lib][module-refactor]) 

Currently, the best way we have to check if a window is closed is to check for window.closed === true following a closure (either programatically or by keypress/mouse-click).  In some instances this fails because the state changes a split second before the window is actually closed, causing the window to actually remain open.  The temporary workaround we have in place is to follow this check with a sleep(0).

We should really find a way to simply check for an event which is fired when the window has finally closed.
I will check how to fix that after bug 639870 has been fixed.
Depends on: 639870
Whiteboard: [mozmill-refactor]
Component: Mozmill Tests → Mozmill Shared Modules
QA Contact: mozmill-tests → mozmill-shared-modules
Whiteboard: [mozmill-refactor] → [module-refactor]
Component: Mozmill Shared Modules → Mozmill Tests
Whiteboard: [module-refactor] → [lib]
Whiteboard: [lib] → [lib][module-refactor]
No longer blocks: 751242
Depends on: 751242
So this has now been fixed by bug 751242 for our current tests. A patch for the test refactor I have put up here:

https://github.com/whimboo/mozmill-test-refactor/pull/3

We can call this fixed.
Assignee: nobody → hskupin
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in before you can comment on or make changes to this bug.