628585 - Pressing ctrl key in Flash doesn't work as expected

Status: VERIFIED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Frank Yan (:fryn)]

I just tried playing Wolfenstein 1-D at the above URL, but when i tried to shoot by pressing the ctrl key, my character instead moved to the left. :mmm and :dolske also experienced this. We all were using the a recent Minefield build on OS X.

I tested the game in Google Chrome on OS X, and the shoot command worked correctly as expected upon pressing the ctrl key. :mmm and i also tested this in Minefield on Windows, and it worked correctly.

Comment 1

[Frank Yan (:fryn)]

This is a regression from 3.6. (I just played Wolfenstein 1-D in Firefox 3.6 with the same Flash plugin, and it worked.)
Not sure if this is a regression from plugin focus fixes for OS X.

Comment 2

[Benjamin Smedberg]

Cocoa event handling? Not a blocker.

Comment 3

[Bob Clary [:bc] (inactive)]

dupe of bug 616177 ?

Comment 4

[Steven Michaud [:smichaud] (Retired)]

> dupe of bug 616177 ?

Possibly.  I'll need to dig further into both bugs.

Comment 5

[Mehdi Mulani [:mmm] (I don't check this)]

Attachment: Always set keyCode.

Instead of setting keyCode if the event is either NSKeyDown or NSKeyUp, this patch also sets the keyCode if the event is a NSFlagsChanged.

Tested this in a build and it seemed to work, the Mac documentation states that this "Raises an NSInternalInconsistencyException if sent to a non-key event." so this seems safe.

Comment 6

[Josh Aas]

Comment on attachment 522444 [details] [diff] [review]
Always set keyCode.

Looks good, thanks!

Comment 7

[Mehdi Mulani [:mmm] (I don't check this)]

http://hg.mozilla.org/mozilla-central/rev/f3c2eea82430

Comment 9

[Frank Yan (:fryn)]

mehdi++!

Would we want to push this to 4.x too?

Comment 10

[Josh Aas]

Yes, we want this for Firefox 4 as soon as possible.

Comment 11

[Mehdi Mulani [:mmm] (I don't check this)]

Comment on attachment 522444 [details] [diff] [review]
Always set keyCode.

This is pretty low risk, only affects Mac users and slightly changes how key events are handled with plugins.

Comment 12

[Daniel Veditz [:dveditz]]

Comment on attachment 522444 [details] [diff] [review]
Always set keyCode.

Approved for mozilla2.0 repository, a=dveditz for release-drivers

Comment 13

[Mehdi Mulani [:mmm] (I don't check this)]

https://hg.mozilla.org/releases/mozilla-2.0/rev/fef83bf61e92

Comment 14

[AndreiD[QA]]

WFM on 
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.2a1pre) Gecko/20110404 Firefox/4.2a1pre