Closed Bug 628606 Opened 9 years ago Closed 9 years ago

elfhack causes bustage since ARM target may not return "arm"

Categories

(Firefox Build System :: General, defect)

ARM
Linux
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla2.0b11

People

(Reporter: m_kato, Assigned: m_kato)

Details

Attachments

(1 file)

# uname -m
armv7l

So, elfhack causes bugstage.

g++-4.4 -fno-rtti -fno-exceptions -Wall -Wpointer-arith -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -Wno-invalid-offsetof -Wno-variadic-macros -Werror=return-type -Wno-long-long -fno-strict-aliasing -fshort-wchar -pthread -march=armv7-a -mthumb -Wa, -march=armv7-a -Wa, -mthumb -pipe -fexceptions  -DNDEBUG -DTRIMMED -Os -freorder-blocks -fomit-frame-pointer  -fPIC -shared -Wl,-z,defs -Wl,-h,test.so -o test.so test.o
rm -f test.so.bak
/media/disk/Development/hg.mozilla.org/objdir-tm-opt/build/unix/elfhack/elfhack -b test.so
test.so: terminate called after throwing an instance of 'std::runtime_error'
  what():  Error opening file


# ls build/unix/elfhack/inject/
armv7l-noinit.c  armv7l-noinit.o  armv7l.c  armv7l.o
Attached patch arm fixSplinter Review
Attachment #506692 - Flags: review?(mh+mozilla)
Attachment #506692 - Flags: review?(mh+mozilla)
Attachment #506692 - Flags: review+
Attachment #506692 - Flags: approval2.0?
Attachment #506692 - Flags: approval2.0? → approval2.0+
Kato-さん, I'll land this tomorrow, with a bunch of other elfhack fixes.
http://hg.mozilla.org/mozilla-central/rev/712162d0a093
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b11
Assignee: nobody → m_kato
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.