Make sure suggestions from <datalist> are shown in Firefox Mobile UI

VERIFIED FIXED

Status

Fennec Graveyard
General
P3
enhancement
VERIFIED FIXED
6 years ago
6 years ago

People

(Reporter: mounir, Assigned: vingtetun)

Tracking

(Blocks: 1 bug, {testcase})

Trunk
testcase
Dependency tree / graph
Bug Flags:
in-testsuite +

Details

Attachments

(4 attachments, 1 obsolete attachment)

(Reporter)

Description

6 years ago
With <datalist> and the list attribute on the input element, authors can provide suggestions to the user. On Firefox Desktop, they are shown like autocomplete suggestions. It would be nice to have them shown in Firefox Mobile given that authors should check if list and datalist are available and might assume that it will work on Firefox Mobile.
(Reporter)

Comment 1

6 years ago
Created attachment 506705 [details]
Testcase
(Reporter)

Updated

6 years ago
Keywords: testcase
Is it going to break Fennec? :D
(Reporter)

Comment 3

6 years ago
It should not ;)
tracking-fennec: --- → ?

Updated

6 years ago
Severity: normal → enhancement
Priority: -- → P3
(Reporter)

Comment 4

6 years ago
I don't think this should be considered as an enhancement: feature detection will return a false positive on Firefox Mobile if it's not implemented.
But it is implemented in Firefox Mobile, isn't it? There's just no UI for it, atm.
(Reporter)

Comment 6

6 years ago
(In reply to comment #5)
> But it is implemented in Firefox Mobile, isn't it? There's just no UI for it,
> atm.

It's implemented in Gecko and Firefox has an UI for it, not Firefox Mobile. That means you can't use the feature in Firefox Mobile.
I'm actually reworking the autocompletion UI for Firefox Mobile, I will have a look to see if I can fix that in the process
tracking-fennec: ? → 2.0next+
If we can't implement a UI for <datalist>, we should show the content of the <datalist> element (as if it was not implemented).

I've recently fixed a similar bug in WebKit : https://bugs.webkit.org/show_bug.cgi?id=52214 and I'd be sad if Firefox made the same mistake :(
Created attachment 516311 [details] [diff] [review]
Patch

The patch add support for the suggestions thought the new autocomplete mechanism. For the moment the suggestions have the same exact look as normal autocomplete results (probably need Madhava's for that)
Assignee: nobody → 21
Attachment #516311 - Flags: review?(mark.finkle)
This patch won't make it for Fennec 4. Please file another bug to do any type of work to disable datalist support from the platform for Fennec 4.0
I have filled bug 638833 for moving to display: inline from  display: none; for the moment.
Blocks: 616348
Depends on: 638833
any screenshots I can see?
Created attachment 523050 [details]
screenshot
Created attachment 523052 [details] [diff] [review]
Patch

And the patch updated on trunk
Attachment #516311 - Attachment is obsolete: true
Attachment #523052 - Flags: review?(mark.finkle)
Attachment #516311 - Flags: review?(mark.finkle)
Comment on attachment 523052 [details] [diff] [review]
Patch

Needs tests!
Attachment #523052 - Flags: review?(mark.finkle) → review+
Created attachment 523186 [details] [diff] [review]
Tests

Tests!
Attachment #523186 - Flags: review?(mark.finkle)
Attachment #523186 - Flags: review?(mark.finkle) → review+
http://hg.mozilla.org/mobile-browser/rev/796cf934cfd1
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
(Reporter)

Updated

6 years ago
Flags: in-testsuite+

Comment 18

6 years ago
Verified on build: Mozilla /5.0 (Android;Linux armv7l;rv:5.0a2) Gecko/20110414
Firefox/5.0a2 Fennec/5.0a2 
Device: LG Optimus 2X (Android 2.2)

The suggestion pop-up flickers when taping in the text field or when you dismiss the keyboard, can you see this too?
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.