628626 - Doorhanger is misplaced when canceling an installation in the add-ons manager

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Srinivas]

User-Agent:       Mozilla/5.0 (Windows NT 6.0; rv:2.0b10pre) Gecko/20110124 Firefox/4.0b10pre
Build Identifier: Mozilla/5.0 (Windows NT 6.1; rv:2.0b10pre) Gecko/20110124 Firefox/4.0b10pre

Doorhanger is not displayed properly after canceling the install of an add-on via add-on manager

Reproducible: Always

Steps to Reproduce:
1.Open Fx, goto Add-on Manager
2.Click on any add-on in Top Add-ons(Add-on Manager->Get Add-ons->Top Add-ons) - Add-on detail page loads
3.Click "Add to Firefox" in Add-on Detail page - Doorhanger will be dispalyed with Add-on download
4.Now click stop in the Doorhanger

Comment 1

[Srinivas]

Attachment: Doorhanger

Comment 2

[Luke Iliffe (Harlequin99)]

Confirmed in new profile on Win7

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Interesting. Happens for any remote installation of add-ons in the add-ons manager. Also visible on OS X.

Comment 4

[:Margaret Leibovic]

It looks like the panel opens in the same place, but the arrow is on the wrong side. This may be an issue with arrow panel arrow positioning, not the popup notifications. We're opening the panel with this.panel.openPopup(anchorElement, "bottomcenter topleft") (http://mxr.mozilla.org/mozilla-central/source/toolkit/content/PopupNotifications.jsm#449), but the arrow is appearing on the top right.

Enn, do you have any ideas what might cause this to happen?

Comment 5

[:Margaret Leibovic]

Attachment: panel is in the same place but arrow is on opposite side

Comment 6

[Neil Deakin]

I didn't see this problem when I tested it. Is this a specific platform?

The patches in bugs 524545, 628238 and 629002 might help here.

Comment 7

[AndreiD[QA]]

I can reproduce the bug following the steps in the description:

1. On a clean profile launch Firefox and open Addons manager.
2. Maximize browser window.
3. In the "GetAddons" -> "Top Addons" section click on an Addon (example: "Adblock Plus")
4. In the Addon's page click on the "Add to Firefox" button
5. When the Doorhanger appears, click on the blue circle with an "x" next to the bar (not the simple "x" in the top right corner).

* OS: Windows 7
  build: Mozilla/5.0 (Windows NT 6.1; rv:2.0b12pre) Gecko/20110207 Firefox/4.0b12pre

** Note: IMO it's something related to the empty space in the tab bar. 
   Example: for me if the browser window is maximized and 5 or more tabs are opened the doorhanger displays correctly.

Comment 8

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

I can reproduce the behavior which is like this bug, following step,
0. Set preference, "devtools.chrome.enabled" is "true".
1. Open ScratchPad and Environment->Browser is enable.
2. Paste following code to ScratchPad and Run it.
/**/
PopupNotifications.show(
  gBrowser.selectedBrowser,
  "test",
  "test",
  "default-notification-icon",
  { label:"ok", accessKey:"o", callback:function(){} },
  null,
  null
);
/**/
**Note: I can reproduce this behavior on:
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:9.0a1) Gecko/20110920 Firefox/9.0a1

I thought this bug is caused by bug 634391.

Comment 9

[Neil Deakin]

Attachment: patch

Looks to be caused by what I described in https://bugzilla.mozilla.org/show_bug.cgi?id=626605#c5

Mounir, do you remember why you added these checks?

Comment 10

[Neil Deakin]

Attachment: patch with test

Comment 11

[Mounir Lamouri (:mounir)]

Comment on attachment 561738 [details] [diff] [review]
patch

Review of attachment 561738 [details] [diff] [review]:
-----------------------------------------------------------------

I have to say I do not remember and I'm not able to understand it either.
Let's remove it then.

Comment 12

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/51f9e410d66f

Comment 13

[Vlad [QA]]

Setting resolution to Verified Fixed on:

Mozilla/5.0 (Windows NT 6.1; rv:10.0a1) Gecko/20111011 Firefox/10.0a1
Mozilla/5.0 (Windows NT 5.1; rv:10.0a1) Gecko/20111011 Firefox/10.0a1
Mozilla/5.0 (X11; Linux i686; rv:10.0a1) Gecko/20111012 Firefox/10.0a1
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:10.0a1) Gecko/20111011 Firefox/10.0a1

I have followed the STR from comment7 and the issue is fixed on latest Nightly.

Comment 14

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Neil, does the automated test has a good enough coverage, or do we need a manual test here?

Comment 15

[Neil Deakin]

I changed the automated test to check for the specific issue caused by this bug.

However, the test doesn't test the addons manager specifically just the underlying problem. I found the addons manager issue difficult to reproduce so a manual test might not be feasible, but probably isn't necessary anyway.