628627 - Should display a message about --disable-elf-hack when elfhack fails

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

Some things that are only warning at the moment should also trigger an actual error (like unsupported relocations)

Comment 1

[Mike Hommey [:glandium]]

Attachment: part 1 - Raise hard errors in some more cases in elfhack

Currently, some errors that are very likely to lead to broken binaries are just displayed as warnings, this makes them hard errors.

Comment 2

[Mike Hommey [:glandium]]

(In reply to comment #1)
> Created attachment 507062 [details] [diff] [review]
> part 1 - Raise hard errors in some more cases in elfhack
> 
> Currently, some errors that are very likely to lead to broken binaries are just
> displayed as warnings, this makes them hard errors.

Also, assertions are only taken into account in debug builds, here we do that in all builds

Comment 3

[Mike Hommey [:glandium]]

Attachment: part 2 - Add messages inviting to file bugs and use --disable-elf-hack in case of elfhack failures

This adds a message before running the elfhack test and running elfhack during packaging to give some awareness about what do do in case of failure

Comment 4

[(dormant account)]

Comment on attachment 507063 [details] [diff] [review]
part 2 - Add messages inviting to file bugs and use --disable-elf-hack in case of elfhack failures

I don't think i'm the right person to review this. I doubt this kind of message spam is even needed.

Comment 5

[Michael Wu [:mwu]]

Comment on attachment 507063 [details] [diff] [review]
part 2 - Add messages inviting to file bugs and use --disable-elf-hack in case of elfhack failures

!summon build peer

Comment 6

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 507063 [details] [diff] [review]
part 2 - Add messages inviting to file bugs and use --disable-elf-hack in case of elfhack failures

Summoned, I take the place that has been prepared for me.



r=me.

Comment 7

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

FTR, I agree in general about message spam, but we've had a lot of bug reports on this tool, would be nice to keep the message until we've flushed them out.

Comment 8

[Mike Hommey [:glandium]]

Taras suggested to remove ac_add_option from the message, what do you think?

Comment 9

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Sure.

Comment 10

[Mike Hommey [:glandium]]

Attachment: part 2 - Add messages inviting to file bugs and use --disable-elf-hack in case of elfhack failures

Let's go with that, then.

Comment 11

[Mike Hommey [:glandium]]

http://hg.mozilla.org/mozilla-central/rev/be7d5e061ba6
http://hg.mozilla.org/mozilla-central/rev/78c74aa85e18