nsCoreUtils::IsXLink looks either incorrect or obsolete

RESOLVED FIXED in mozilla19

Status

()

Core
Disability Access APIs
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: hsivonen, Assigned: surkov)

Tracking

(Blocks: 1 bug)

unspecified
mozilla19
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
The method nsCoreUtils::IsXLink seems to treat an element as an XLink link only if xlink:type="simple" is present. If this code is for the old generic XLink support, the code is obsolete, because generic XLink support is gone. If this code is for SVG, it is incorrect, because SVG doesn't require xlink:type.
(Assignee)

Comment 1

6 years ago
It is about XLink only. We use accessible of generic type for SVG, though we should be more diverse.
(Assignee)

Updated

6 years ago
Blocks: 389800
(Assignee)

Comment 2

5 years ago
let's make sure to address xlink stuff for svg in bug 809744 and remove nsCoreUtils::IsXLink for now.
(Assignee)

Comment 3

5 years ago
Created attachment 679541 [details] [diff] [review]
patch
Assignee: nobody → surkov.alexander
Status: NEW → ASSIGNED
Attachment #679541 - Flags: review?(trev.saunders)
Attachment #679541 - Flags: review?(trev.saunders) → review+
(Assignee)

Comment 4

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/4586e6f3c550
https://hg.mozilla.org/mozilla-central/rev/4586e6f3c550
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
You need to log in before you can comment on or make changes to this bug.