Closed
Bug 628649
Opened 13 years ago
Closed 12 years ago
nsCoreUtils::IsXLink looks either incorrect or obsolete
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
mozilla19
People
(Reporter: hsivonen, Assigned: surkov)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
6.58 KB,
patch
|
tbsaunde
:
review+
|
Details | Diff | Splinter Review |
The method nsCoreUtils::IsXLink seems to treat an element as an XLink link only if xlink:type="simple" is present. If this code is for the old generic XLink support, the code is obsolete, because generic XLink support is gone. If this code is for SVG, it is incorrect, because SVG doesn't require xlink:type.
Assignee | ||
Comment 1•13 years ago
|
||
It is about XLink only. We use accessible of generic type for SVG, though we should be more diverse.
Assignee | ||
Comment 2•12 years ago
|
||
let's make sure to address xlink stuff for svg in bug 809744 and remove nsCoreUtils::IsXLink for now.
Assignee | ||
Comment 3•12 years ago
|
||
Assignee: nobody → surkov.alexander
Status: NEW → ASSIGNED
Attachment #679541 -
Flags: review?(trev.saunders)
Updated•12 years ago
|
Attachment #679541 -
Flags: review?(trev.saunders) → review+
Assignee | ||
Comment 4•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/4586e6f3c550
Comment 5•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/4586e6f3c550
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
You need to log in
before you can comment on or make changes to this bug.
Description
•