Closed Bug 628660 Opened 13 years ago Closed 5 years ago

Ghost tabs appear when pressing return in a text box

Categories

(Firefox for Android Graveyard :: General, defect)

ARM
Android
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: ioana.chiorean, Assigned: vingtetun)

References

Details

Attachments

(4 files, 1 obsolete file)

Attached image ghost tab
Device: HTC Desire A8181
BuildID: Mozilla /5.0 (Android;Linux armv7l;rv:2.0b8pre) Gecko/20101021
Firefox/4.0b8pre Fennec /4.0b2pre  

Steps to reproduce:

1. go to http://people.mozilla.com/~tchung/html_tp/formsninputv2.html
2. scroll down to the text area box
3. click in the text area box and keep hitting return fast until the caret is at the bottom of the text area box.

Expected result:
- no ghost thumbnail appears and the caret will still be in focus

Actual result:
- ghost tabs appear and the page is covered by the light pink color

Note: 
- please see attached photo
please state if you need also a video
I cannot reproduce it in a build with the patch in bug 628732.

I see what you described as a light pink color (I will provide a fix for it) but no tab.
Depends on: 628732
Attached patch Patch (obsolete) — Splinter Review
Attachment #507424 - Flags: review?(mark.finkle)
Comment on attachment 507424 [details] [diff] [review]
Patch

Shouldn't the zoom code be doing this?
(In reply to comment #4)
> Comment on attachment 507424 [details] [diff] [review]
> Patch
> 
> Shouldn't the zoom code be doing this?

I was thinking that too but the zoom code take another path, it uses rootView._contentView.scrollTo instead of rootView.scroll (http://mxr.mozilla.org/mobile-browser/source/chrome/content/browser.js#1038) to not update the displayport :/
Zoom code is in fact calling updateCacheViewport when it sets browser.scale.
(In reply to comment #6)
> Zoom code is in fact calling updateCacheViewport when it sets browser.scale.

hmm, maybe there is a failure because the scale does not change and so updateCacheViewport is not called?
I will check that, thanks.
Good point, scale will not update viewport in that case.
Attached patch PatchSplinter Review
Added a manual call to _updateCacheViewport in setVisibleRect if the scale level does not change
Assignee: nobody → 21
Attachment #507424 - Attachment is obsolete: true
Attachment #507503 - Flags: review?(mark.finkle)
Attachment #507503 - Flags: review?(ben)
Attachment #507424 - Flags: review?(mark.finkle)
Comment on attachment 507503 [details] [diff] [review]
Patch

Hacky of course, but nothing we can do right now.

Luckily, I think I will soon have a good api for this kind of thing!
Attachment #507503 - Flags: review?(ben) → review+
Attachment #507503 - Flags: review?(mark.finkle) → review+
http://hg.mozilla.org/mobile-browser/rev/07ebdaffee36
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Build ID: Mozilla /5.0 (Android;Linux armv7l;rv:2.0b11pre) Gecko/20110128 Firefox/4.0b11pre Fennec /4.0b5pre 

No ghost tab can be seen, but that light pink color, which looks now like a checkerboard is still visible to the user. (please see the attached photo).

As a result of the above mentioned, I will not mark this bug as being verified fixed.
Attached image checkerboard
Reopening. Vivien, can you reproduce?
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Build Identifier: Mozilla/5.0 (Android; Linux armv7l; rv:2.0b12pre)
Gecko/20110202 Firefox/4.0b12pre Fennec/4.0b5pre 
Device HTC Desire A8181
OS: Android 2.1

Steps to reproduce:
1. Open several tabs 
2. Open a page from All pages from Awesome list
(In reply to comment #15)
> Created attachment 509401 [details]
> ghost tabs appear also when loading a page
> 
> Build Identifier: Mozilla/5.0 (Android; Linux armv7l; rv:2.0b12pre)
> Gecko/20110202 Firefox/4.0b12pre Fennec/4.0b5pre 
> Device HTC Desire A8181
> OS: Android 2.1
> 
> Steps to reproduce:
> 1. Open several tabs 
> 2. Open a page from All pages from Awesome list

I have not seen this in a while. Could we close it?
Closing all opened bug in a graveyard component
Status: REOPENED → RESOLVED
Closed: 13 years ago5 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: