628686 - Hitting return when summarizing article changes inserts bold text

Status: RESOLVED WORKSFORME

(support.mozilla.org :: Knowledge Base Software, task, P3)

Description

[Verdi [:verdi] Best to slack me]

1. Submit an article for review 
2. Summarize your changes in the overlay dialog.
3. Hit enter or return on your keyboard instead of clicking the dialog button.
Result - '''Bold text''' will be inserted into your document.

Expected result: The submit button should be activated and no extra text should be inserted in the article.

Comment 1

[Underpass]

I can confirm the effect (I found "Bold text" around very often in my translations) but I cannot confirm the way to reproduce it.

I mean, I think I have never used the keyboard but still the error happens. I will try to update the bug as soon as I find a way to have the error again.

Comment 3

[Ricky Rosario [:rrosario, :r1cky]]

I've seen similar behavior in other places where we use the editor toolbar. I think it is a matter of removing the toolbar buttons from the tab order (using tabindex?). This would also fix tabbing through the form fields to go straight to the textarea as expected.

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

Bumping to 2012.6.

Comment 5

[Ricky Rosario [:rrosario, :r1cky]]

Sprint based milestone :-)

Comment 6

[Ricky Rosario [:rrosario, :r1cky]]

Tobbi looked at this a bit and wasn't able to repro. I just tried on stage and hitting enter from the change summary box submits the form as expected and I don't see any '''Bold text''' in the edit.