Closed
Bug 628695
Opened 13 years ago
Closed 13 years ago
Make invalid form popup offset aware of the zoom level
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 4.0b12
People
(Reporter: mounir, Assigned: mounir)
References
Details
Attachments
(1 file)
|
1.39 KB,
patch
|
enndeakin
:
review+
jst
:
approval2.0+
|
Details | Diff | Splinter Review |
This patch pass an offset aware of the zoom level to openPopup but we could also have openPopup change the offset value but it might break some things (unlikely I guess but still risky so close to a release). Neil, let me know if you think we should open a follow-up to make openPopup change the offset value.
Attachment #506778 -
Flags: review?(enndeakin)
|
Assignee | |
Updated•13 years ago
|
Assignee: nobody → mounir.lamouri
Status: NEW → ASSIGNED
|
||
Comment 1•13 years ago
|
||
Comment on attachment 506778 [details] [diff] [review] Patch v1 I think this is better than changing openPopup, as I think the offset should be in the coordinate system of the popup rather than the anchor.
Attachment #506778 -
Flags: review?(enndeakin) → review+
|
|
Assignee | |
Updated•13 years ago
|
Attachment #506778 -
Flags: approval2.0?
|
|
Assignee | |
Updated•13 years ago
|
Whiteboard: [needs approval]
|
|
Assignee | |
Updated•13 years ago
|
Whiteboard: [needs approval] → [needs approval][passed try]
|
||
Updated•13 years ago
|
Attachment #506778 -
Flags: approval2.0? → approval2.0+
|
|
Assignee | |
Comment 2•13 years ago
|
||
Pushed: http://hg.mozilla.org/mozilla-central/rev/2efc7cc537d7
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [needs approval][passed try]
Target Milestone: --- → Firefox 4.0b12
You need to log in
before you can comment on or make changes to this bug.
Description
•