Closed Bug 628794 Opened 9 years ago Closed 9 years ago
Crash [@ ns
IDOMElement CSSInline Style _Get Style], SVG element with HTML __proto __
Like bug 585745, but with SVG instead of MathML.
Only crashes in debug builds.
Ugh. I hate JS.... peter, _this_ one we could solve by having a separate base class that SVG inherits from that doesn't include GetStyle and casting to that class here (MathML, HTML, XUL would all still inherit from it). Or I could expand the namespace check to exclude SVG. Preferences?
Assignee: nobody → bzbarsky
blocking2.0: --- → ?
Priority: -- → P1
I'm starting to remember why I didn't use custom unwrapping for GetStyle :-(. I'd personally go with the separate base class, but both options are fine.
Not blocking on this at this late of a point in the release. But I'd approve a safe fix.
blocking2.0: ? → -
Comment on attachment 515739 [details] [diff] [review] SVG and HTML/XUL .style come from different interfaces. The other option is to leave nsStyledElement as is, and name the new class nsStyledElementWithElementCSSInlineStyle.
Attachment #515739 - Flags: review?(peterv) → review+
Whiteboard: [need review] → [need landing]
Whiteboard: [need landing] → fixed-in-cedar
Target Milestone: --- → mozilla2.2
Comment on attachment 515739 [details] [diff] [review] SVG and HTML/XUL .style come from different interfaces. We should probably land this crash fix on 2.0.x too.
Attachment #515739 - Flags: approval2.0?
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Attachment #515739 - Flags: approval2.0? → approval2.0-
Crash Signature: [@ nsIDOMElementCSSInlineStyle_GetStyle]
You need to log in before you can comment on or make changes to this bug.