Closed Bug 628794 Opened 9 years ago Closed 9 years ago

Crash [@ nsIDOMElementCSSInlineStyle_GetStyle], SVG element with HTML __proto__

Categories

(Core :: XPConnect, defect, P1, critical)

x86
macOS
defect

Tracking

()

RESOLVED FIXED
mozilla5
Tracking Status
blocking2.0 --- -

People

(Reporter: jruderman, Assigned: bzbarsky)

References

(Blocks 1 open bug)

Details

(Keywords: crash, testcase)

Crash Data

Attachments

(2 files)

Like bug 585745, but with SVG instead of MathML.
Only crashes in debug builds.
Ugh.  I hate JS....  peter, _this_ one we could solve by having a separate base class that SVG inherits from that doesn't include GetStyle and casting to that class here (MathML, HTML, XUL would all still inherit from it).  Or I could expand the namespace check to exclude SVG.  Preferences?
Assignee: nobody → bzbarsky
blocking2.0: --- → ?
Priority: -- → P1
I'm starting to remember why I didn't use custom unwrapping for GetStyle :-(. I'd personally go with the separate base class, but both options are fine.
Not blocking on this at this late of a point in the release. But I'd approve a safe fix.
blocking2.0: ? → -
Whiteboard: [need review]
Comment on attachment 515739 [details] [diff] [review]
SVG and HTML/XUL .style come from different interfaces.

The other option is to leave nsStyledElement as is, and name the new class nsStyledElementWithElementCSSInlineStyle.
Attachment #515739 - Flags: review?(peterv) → review+
Whiteboard: [need review] → [need landing]
http://hg.mozilla.org/projects/cedar/rev/258a0f209565
Flags: in-testsuite+
Whiteboard: [need landing] → fixed-in-cedar
Target Milestone: --- → mozilla2.2
Comment on attachment 515739 [details] [diff] [review]
SVG and HTML/XUL .style come from different interfaces.

We should probably land this crash fix on 2.0.x too.
Attachment #515739 - Flags: approval2.0?
http://hg.mozilla.org/mozilla-central/rev/258a0f209565
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: fixed-in-cedar
Attachment #515739 - Flags: approval2.0? → approval2.0-
Crash Signature: [@ nsIDOMElementCSSInlineStyle_GetStyle]
Blocks: 584293
You need to log in before you can comment on or make changes to this bug.