Closed Bug 628800 Opened 12 years ago Closed 12 years ago

VALIDATE_STATUS should always be 1 on MacOS X

Categories

(Core :: Graphics: CanvasWebGL, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: vlad, Assigned: vlad)

Details

Attachments

(1 file)

We never call ValidateProgram on OSX, because it can cause a crash in drivers.  However, we need to force GL_VALIDATE_STATUS to be 1, because otherwise it will always be 0 (since we never called validate).
Attachment #506902 - Flags: review?(bjacob)
Comment on attachment 506902 [details] [diff] [review]
fix validate status

r+, but with the following change: only do this on NVIDIA cards, and add a comment there. We are only avoiding glValidateProgram on NVIDIA cards on mac.
Attachment #506902 - Flags: review?(bjacob) → review+
http://hg.mozilla.org/mozilla-central/rev/c0e58545ce43
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.