Closed
Bug 628800
Opened 14 years ago
Closed 14 years ago
VALIDATE_STATUS should always be 1 on MacOS X
Categories
(Core :: Graphics: CanvasWebGL, defect)
Core
Graphics: CanvasWebGL
Tracking
()
RESOLVED
FIXED
People
(Reporter: vlad, Assigned: vlad)
Details
Attachments
(1 file)
|
780 bytes,
patch
|
bjacob
:
review+
|
Details | Diff | Splinter Review |
We never call ValidateProgram on OSX, because it can cause a crash in drivers. However, we need to force GL_VALIDATE_STATUS to be 1, because otherwise it will always be 0 (since we never called validate).
Attachment #506902 -
Flags: review?(bjacob)
|
||
Comment 1•14 years ago
|
||
Comment on attachment 506902 [details] [diff] [review]
fix validate status
r+, but with the following change: only do this on NVIDIA cards, and add a comment there. We are only avoiding glValidateProgram on NVIDIA cards on mac.
Attachment #506902 -
Flags: review?(bjacob) → review+
|
Assignee | |
Comment 2•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•