628890 - mochitests-2: test_bug509055.html should not call SimpleTest.finish() before it actually has

Status: VERIFIED FIXED

(Core Graveyard :: History: Global, defect)

Description

[Serge Gautherie (:sgautherie)]

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1296007795.1296008703.26408.gz&fulltext=1
OS X 10.6 comm-central-trunk debug test mochitests-2/5 on 2011/01/25 18:09:55
{
...
460 INFO TEST-PASS | /tests/docshell/test/test_bug509055.html | SHEntry's title should change when we change. - "Changed" should equal "Changed"
461 INFO TEST-END | /tests/docshell/test/test_bug509055.html | finished in 2976ms
462 INFO TEST-START | /tests/docshell/test/test_bug511449.html
Final yield.
...
}

I noticed this while checking bug 556687:
I assume they are unrelated but it would be preferable to be sure(r).

NB: This would be fixed by bug 615546, if it was allowed to stay in the tree :-<

Comment 1

[Justin Lebar (not reading bugmail)]

The code in question is:

  SimpleTest.finish();
  dump('Final yield.\n');
  yield;
} // end of test

It would probably be reasonable to call SimpleTest.finish() after the yield.  I dunno if that would fix any problems you're observing, though.

Comment 2

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) Wrap the call in SimpleTest.executeSoon() (ftb) [Checked in: Comment 5]

Comment 3

[Justin Lebar (not reading bugmail)]

Hm.  Yes, I think that patch is better than moving the SimpleTest.finish().  If we move the finish(), it never gets called.  But if we take out the yield, we get a StopIteration exception.

Comment 4

[Serge Gautherie (:sgautherie)]

["Mid-air collision detected!" ...]

(In reply to comment #1)

> I dunno if that would fix any problems you're observing, though.

Probably not, but it will sort the log out at least.

Comment 5

[Serge Gautherie (:sgautherie)]

Comment on attachment 507019 [details] [diff] [review]
(Av1) Wrap the call in SimpleTest.executeSoon() (ftb)
[Checked in: Comment 5]

http://hg.mozilla.org/mozilla-central/rev/cb707fbc99d4

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/bd974e9f527a

Comment 6

[Serge Gautherie (:sgautherie)]

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1296067541.1296068149.30123.gz&fulltext=1
Rev3 Fedora 12x64 mozilla-central opt test mochitests-2/5 on 2011/01/26 10:45:41
{
554 INFO TEST-START | /tests/docshell/test/test_bug509055.html
Waiting for initial load.
Got initial load.  Spinning event loop.
Waiting for hashchange.
onChildHashchange() called.
Waiting for second hashchange.
onChildHashchange() called.
Got second hashchange.  Spinning event loop.
555 INFO TEST-PASS | /tests/docshell/test/test_bug509055.html | SHEntry's title should change when we change. - "Changed" should equal "Changed"
Final yield.
556 INFO TEST-END | /tests/docshell/test/test_bug509055.html | finished in 357ms
}

V.Fixed