628893 - Fix use of enum and other reserved words since Bug 497869 landed

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[Philip Chee]

Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b10pre) Gecko/20110125 SeaMonkey/2.1b2pre

Error: enum is a reserved identifier
Source file: resource://gre/components/smileApplication.js
Line: 365, Column: 8
Source code:
    var enum = Utilities.windowMediator.getEnumerator("navigator:browser"); 

Error: Factory not registered = NS_ERROR_FACTORY_NOT_REGISTERED
Source file: chrome://communicator/content/bindings/notification.xml
Line: 1175

Comment 1

[Philip Chee]

Attachment: Patch Ev1.0 fix enum strict errors [Checked in: Comment 2]

Comment 2

[Philip Chee]

Comment on attachment 507029 [details] [diff] [review]
Patch Ev1.0 fix enum strict errors
[Checked in: Comment 2]

Pushed to comm-central
http://hg.mozilla.org/comm-central/rev/75488924c92f

Leaving open in case other strict errors crop up.

Comment 3

[Philip Chee]

Jens, You might want to take note of this:

> +++ b/browser/base/content/syncSetup.js
> @@ -875,19 +875,19 @@ var gSyncSetup = {
>    _setFeedback: function (element, success, string) {
>      element.hidden = success || !string;
> -    let class = success ? "success" : "error";
> +    let classname = success ? "success" : "error";
>      let image = element.getElementsByAttribute("class", "statusIcon")[0];
> -    image.setAttribute("status", class);
> +    image.setAttribute("status", classname);

Comment 4

[Jens Hatlak (:InvisibleSmiley)]

(In reply to comment #3)
> Jens, You might want to take note of this:

TUVM! Will take care of it in bug 618709 / bug 576970.

Comment 5

[Serge Gautherie (:sgautherie)]

Bustage-fix for bug 576970 comment 178:
http://hg.mozilla.org/comm-central/rev/0f313f7b192e
(AAv1) Fix xpcshell bustage from bug 576970, copied from bug 497869

Comment 6

[Serge Gautherie (:sgautherie)]

Ftr, from bug 497869:
*syncSetup.js: Jens did it.
*nsBrowserGlue.js: I did it.
*fuelApplication.js: Philip did it
;-)

Let's reopen if need be.