628951 - Remember Password pop-up has poor keyboard accessibility

Status: RESOLVED WORKSFORME

(Toolkit :: Password Manager, defect)

Description

[K Chayka]

User-Agent:       Mozilla/5.0 (Windows NT 5.1; rv:2.0b10pre) Gecko/20110122 Firefox/4.0b10pre SeaMonkey/2.1b2pre
Build Identifier: Mozilla/5.0 (Windows NT 5.1; rv:2.0b10pre) Gecko/20110122 Firefox/4.0b10pre SeaMonkey/2.1b2pre

After entering new login info at a site, the "remember password" dialog pops up as expected. This does not appear to automatically have focus--pressing the enter key to accept the "remember" setting does nothing. This dialog used to have a keyboard shortcut, ALT+R, to accept "remember" and dismiss the box. There is no longer a shortcut so it is no longer easily keyboard accessible. From trial and error I figured out that tabbing a few times gives it focus so the enter key works for the "remember" value, but getting the drop-down list to show any other value is way more cumbersome, there is no way to tell when the arrow even has focus. This is not good accessibility, or usability.

Reproducible: Always

Steps to Reproduce:
1. Go to any site that takes a login that might be remembered (some don't allow it, like banks). I used http://www.pdnonline.com/pdn/subscribe/login/login.jsp
2. Enter anything in the username and password fields and submit
3. The Remember Password dialog pops up, the "remember" value apparently selected by default
4. Press the enter key
Actual Results:  
Nothing happens. Press the tab key until the focus outline shows on the "remember" value, then the enter key works for that value.

Expected Results:  
Bring back the ALT+R shortcut, if nothing else, but I expect Seamonkey keyboard accessibility to be better than this.

Comment 1

[Philip Chee]

It should be "R" according to the code but I''m not sure why it isn't showing up.

Punting to the login manager people.

Comment 2

[Comorasu Cristian]

I was able to reproduce this on Fx 47.0b4-build1 (20160509171155), 48.0a2-build2 (20160511004106), 49.0a1-build1 (20160508030214) ; using the following platforms: Windows 10 x64, Ubuntu 14.04 LTS x64, 49.0a1-build1 (20160508030214).

Comment 3

[Matthew N. [:MattN]]

Ctrl-S works on macOS, Alt-S works on non-Mac.

Source: https://searchfox.org/mozilla-central/rev/bee8cf15c901b9f4b0c074c9977da4bbebc506e3/toolkit/locales/en-US/chrome/passwordmgr/passwordmgr.properties#13