629026 - After a crash Mozmill does not always close down safely ('MozMill' object has no attribute 'current_test')

Status: VERIFIED FIXED

(Testing Graveyard :: Mozmill, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Using the nightly tester tools to simulate a crash I got the following exception:

Traceback (most recent call last):
  File "/Volumes/data/testing/envs/dev/bin/mozmill", line 8, in <module>
    load_entry_point('mozmill==1.5.2pre', 'console_scripts', 'mozmill')()
  File "/Volumes/data/build/tools/mozmill/mozmill/mozmill/__init__.py", line 839, in cli
    CLI().run()
  File "/Volumes/data/build/tools/mozmill/mozmill/mozmill/__init__.py", line 795, in run
    self.mozmill.report_disconnect()               
  File "/Volumes/data/build/tools/mozmill/mozmill/mozmill/__init__.py", line 312, in report_disconnect
    test = self.current_test
AttributeError: 'MozMill' object has no attribute 'current_test'

Steps:
1. Download https://addons.mozilla.org/de/firefox/addon/nightly-tester-tools/ and update the max version
2. Edit the first test in the testAwesomeBar folder and add a sleep(10000) in the setupModule
3. Start Mozmill like: mozmill -b %app% -t firefox/testAwesomeBar --addons=ntt.xpi
4. Once Firefox has been started kill it via Tools | Nightly Tester Tools

Right after step 4 you will see the following Python exception.

We loose all the results from such a testrun. I request blocking 1.5.2

Comment 1

[cmtalbert]

Followed your steps on windows, I don't see this behavior.

I see that we report the test as failed and mozmill shuts down properly.  Nothing is left running.  This is true whether the test that crashes is first or somewhere in the middle of the directory of tests.

You still get output detailing which test failed, i.e.:
$ mozmill -b "C:\Program Files (x86)\Minefield\firefox.exe" -t ../mozmill-tests
/firefox/testAwesomeBar --addons=ntt.xpi
TEST-START | c:\Users\ctalbert\projects\mozmill-tests\firefox\testAwesomeBar\tes
tAccessLocationBar.js | setupModule
TEST-UNEXPECTED-FAIL | Disconnect Error: Application unexpectedly closed
INFO Passed: 0
INFO Failed: 1
INFO Skipped: 0

I don't think this blocks.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Clint, can you please test this on the platform I have reported on?

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Hey guys, can you please check if you an reproduce my problem mentioned in comment 0? I still think it's important. In my case we lose all the test results from a test-run when a crash happens. Nothing will be reported. Thanks.

Comment 4

[cmtalbert]

(In reply to comment #2)
> Clint, can you please test this on the platform I have reported on?

Certainly, next time it would be very helpful for you to mention that in comment 0 or not file the bug as reproducible on All platforms.

Comment 5

[Aaron Train [:aaronmt]]

Using 1.5.2pre on Linux performing your steps in comment #0.

aronmt@ubuntu:~/Mozilla/mozmill-tests$ mozmill -t
firefox/testAwesomeBar/testAccessLocationBar.js -b ../default/firefox
--addons=ntt.xpi
TEST-START |
/home/aaronmt/Mozilla/mozmill-tests/firefox/testAwesomeBar/testAccessLocationBar.js
| setupModule
TEST-UNEXPECTED-FAIL | Disconnect Error: Application unexpectedly closed
INFO Passed: 0
INFO Failed: 1
INFO Skipped: 0

Comment 6

[cmtalbert]

(In reply to comment #3)
> Hey guys, can you please check if you an reproduce my problem mentioned in
> comment 0? I still think it's important. In my case we lose all the test
> results from a test-run when a crash happens. Nothing will be reported. Thanks.

Can't repro on mac either.

Henrik, this looks specific to your setup.

Comment 7

[Aaron Train [:aaronmt]]

Same output on OSX w/1.5.2pre

AaronMT@AaronMT~: mozmill -t
firefox/testAwesomeBar/testAccessLocationBar.js -b ../default/firefox
--addons=ntt.xpi
TEST-START |
/Users/AaronMT/mozmill-tests/firefox/testAwesomeBar/testAccessLocationBar.js
| setupModule
TEST-UNEXPECTED-FAIL | Disconnect Error: Application unexpectedly closed
INFO Passed: 0
INFO Failed: 1
INFO Skipped: 0

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Ok, something went wrong with my local 1.5.2 sandbox. Instead of running the dev build it had references to Mozmill 1.5.1. After fixing this I don't see the problem anymore. That means it has been fixed with bug 616383. Also tested on other platforms and I can confirm it works on Linux too with 1.5.2.

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Tested today again a couple of times and I wasn't able to reproduce my initial reported behavior with 1.5.2 RC2. Marking as verified fixed.