629067 - Allow sorting of signature lists by date of first occurrence

Status: RESOLVED FIXED

(Socorro :: General, task)

Description

[Laura Thomson :laura]

As per 
https://wiki.mozilla.org/Socorro:PRD_2.x#New_.2F_explosive_.2F_critical_crash_tracking

Might slip to 1.7.8 since it depends on bug 629054

Comment 1

[Ryan Snyder [:ryansnyder] [:rsnyder] [:rysny]]

Will need to update sql in fetchTopcrasherVersions() in Topcrashers_Model with:

SELECT 
  sd.signature, 
  array_to_string(array_agg(pd.version ORDER BY sort_key),', '),
  min(first_report) as first_report 
FROM signature_productdims sd 
INNER JOIN productdims pd ON sd.productdims_id = pd.id 
WHERE sd.signature IN (" . implode(", ", $signatures) . ") 
AND pd.product = ? 
ORDER BY signature;

Comment 2

[[:jberkus] Josh Berkus]

Ryan,

That'll allow us to display the first occurance info.

Making it sortable, though ... that requires an overhaul of TCBS.

Comment 3

[Ryan Snyder [:ryansnyder] [:rsnyder] [:rysny]]

Right, agreed.  TCBS requires an overhaul and I definitely still want that to happen.

I was thinking that we can do a poor man's sorting using jquery's tablesorter.  It's only for the 300 signatures listed on the current page, but should suffice for an immediate solution...  Duct tape, FTW.

Comment 4

[Ryan Snyder [:ryansnyder] [:rsnyder] [:rysny]]

Committing this change on the PHP side.

==

Sending        controllers/topcrasher.php
Sending        models/topcrashers.php
Sending        views/common/list_topcrashers.php
Transmitting file data ...
Committed revision 2960.

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

Not sure it's caused by this, but we started failing some topcrasher tests:

http://qa-selenium.mv.mozilla.com:8080/job/socorro/712/

The previous build (6 hours before it) was only failing one test:

http://qa-selenium.mv.mozilla.com:8080/job/socorro/711/console

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Spun comment 5's failure(s) off as bug 636375.

Comment 7

[Ryan Snyder [:ryansnyder] [:rsnyder] [:rysny]]

Ah, thanks Stephen. This change must have only been made to devdb and not stagedb.  I can back the change out if need be for code freeze tomorrow.

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

Noticed that not all stacks have a date appear in the First Appearance column; is that expected?

https://crash-stats.stage.mozilla.com/topcrasher/byversion/Firefox/4.0b13pre

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Post-fix screenshot

Comment 10

[Stephen Donner [:stephend] Not actively reading bugmail]

(The screenshot in comment 9 shows it sorting successfully for the dates it has, though.  Just wondering, per comment 8, if all stacks are supposed to have a corresponding First Appearance timestamp?)